Skip to content

keep-nip46: surface malformed register_wallet hmac hex as InvalidInput #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kwsantiago merged 1 commit into from
Jul 16, 2026
+5 −1
Merged

keep-nip46: surface malformed register_wallet hmac hex as InvalidInput #830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion keep-nip46/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,8 +366,12 @@ impl Nip46Client {
}
let decode_result = hex::decode(hex_str.trim());
hex_str.zeroize();
// Malformed hex (odd length, non-hex chars) is an untrusted-input
// validation failure, same class as the too-long / wrong-length
// checks around it; surface it as InvalidInput so callers can
// handle all three consistently, not as a StorageErr.
let decoded = decode_result.map_err(|e| {
StorageError::invalid_format(format!("register_wallet hmac hex: {e}"))
KeepError::InvalidInput(format!("register_wallet hmac hex: {e}"))
})?;
if decoded.len() != HMAC_SHA256_LEN {
return Err(KeepError::InvalidInput(format!(
Expand Down