Skip re-fetching PRs already merged/closed#9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily deploys on the built-in token spent ~20 min because
--ingestre-fetched all ~900 spec PRs each run (TTL 1 day), most of them long-since merged upstream.pr_statusnow reuses a cached terminal state (merged/closed/missing) past its TTL instead of spending an API call — those never change — and touches the cache mtime so it stays display-fresh. Only open (and uncached) PRs actually hit the network, so the ingest drops from ~900 to the ~100 open PRs and finishes in a couple minutes. A reopened PR is rare and self-heals on a manual refresh (refresh=1bypasses this).Verified: a merged entry is reused past TTL with no network call (even with a bad token); an open entry still fetches.