Stop ingest on rate limit instead of hammering doomed requests#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no PAT, the deploy uses the built-in token (1000/hr), which the ~900-PR spec ingest exceeds. The loops caught
RateLimitedper-PR and kept going, firing hundreds of doomed 403s and making each deploy take 10+ minutes.Now both ingest loops stop as soon as they hit the limit and keep cached status for the rest. The Knots view is built first (fresh budget, ~150 calls) so it still gets fresh data; the spec is best-effort. Deploys finish fast.