Skip to content

Fix hidden tag hover on node list #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CJFWeatherhead merged 3 commits into from
Jul 3, 2026
Merged

Fix hidden tag hover on node list #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dffafb3
Track node tag popup open state
EdGeraghty Jul 3, 2026
4a122f3
Add new style to keep tag popup uppermost on open
EdGeraghty Jul 3, 2026
ed3bba4
Merge branch 'main' into fix/hidden-tag-hover
CJFWeatherhead Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/lib/cards/node/NodeListCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,21 @@

</script>

<style>
:global(.node-list-card) {
position: relative;
z-index: 0;
}

:global(.node-list-card:has([data-popup-open='true'])) {
z-index: 60;
}
</style>

<AccordionItem
{open}
bind:id={node.id}
class="backdrop-blur-xl backdrop-brightness-100 bg-white/25 dark:bg-white/5 rounded-md"
class="node-list-card backdrop-blur-xl backdrop-brightness-100 bg-white/25 dark:bg-white/5 rounded-md"
padding="py-4 px-4"
regionControl="!rounded-none"
>
Expand Down
13 changes: 11 additions & 2 deletions src/lib/parts/NodeTagsIcon.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,25 @@
id: string;
};
let { tags, id }: NodeTagsIconProps = $props();
let popupOpen = $state(false);

const popupHover = $derived<PopupSettings>({
event: 'hover',
target: `tags-popup-${id}`,
placement: 'bottom',
});
state: ({ state }) => {
popupOpen = state;
},
};
</script>

{#if tags.length > 0}
<span class="inline-flex items-center" use:popup={popupHover} data-testid="node-tags-icon">
<span
class="inline-flex items-center"
use:popup={popupHover}
data-testid="node-tags-icon"
data-popup-open={popupOpen}
>
<RawMdiTag class="text-warning-500 dark:text-warning-400 cursor-help" />
</span>
<div class="card p-3 variant-filled-surface shadow-xl z-50" data-popup="tags-popup-{id}">
Expand Down
Loading