chore: de-squad branch-naming convention (#476)#480
Merged
Conversation
Closes #476 Dropped the branch-ancestry check entirely (Option B per Earl's decision 2026-06-12) -- the test stubs already assumed it was gone. Renamed all cast-name sample branches (pluto/*, squad/*) to feat/* equivalents in test_precommit_hygiene.sh and test_windows_setup.ps1. Check 3 (refuse direct commits to develop/main/master) is retained unchanged. Renumbered hook checks 2/3/4 -> 1/2/3 and updated branch-suggestion in the help message to feat/<issue>-<slug>. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Deletes the 3 vestigial T1a/T1b/T1c no-op passes left behind when the branch-ancestry check was removed in #476. Those stubs asserted nothing and always passed, inflating the test count by 3. Renumbers section headers and test-ID prefixes to match the hook's real 3-check structure: Check 1=ASCII-only, Check 2=protected-branch, Check 3=shellcheck. Updates the file's top header comment block to drop the ancestry line and the stale 4-check count. Test tally: 18 -> 15. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #476
Summary
Drops the branch-ancestry check entirely (Option B, decided by Earl 2026-06-12 -- supersedes the earlier "generalize" plan). The hygiene test stubs were already half-removed; Option B completes the migration cleanly.
Files changed (3)
hooks/pre-commit-- removed thesquad/*ancestry guard (old Check 1 + itscaseblock); renumbered the remaining checks so they read 1 = ASCII-only, 2 = refuse direct commits to develop/main/master, 3 = shellcheck; updated the branch suggestion in the help text tofeat/<issue>-<slug>.tests/test_precommit_hygiene.sh-- removed the three no-op ancestrypassstubs (T1a/T1b/T1c) and the dead "Check 1" section they lived in; renumbered the test sections + IDs to match the hook's real 3-check order; renamed the cast-name sample branchpluto/249-fix->feat/249-fix(T3e -> T2e); fixed the header comment.tests/test_windows_setup.ps1-- renamed cast-name sample branches used as test data:pluto/ascii-fail->feat/ascii-fail(Y-1),pluto/ascii-pass->feat/ascii-pass(Y-2),squad/224-test->feat/224-test(Y-5),squad/224-advisory-test->feat/224-advisory-test(Y-6). These are sample data only -- they exercise the pre-push guard (test: add behavioral coverage for pre-commit + pre-push hooks #224), not branch naming.What is retained
The "refuse direct commits to develop/main/master" check (now Check 2) is retained unchanged -- it is a general protected-branch guard, not squad-specific.
Local verification
sh -n(POSIX syntax): PASStest_precommit_hygiene.sh: 15/15 PASS (down from 18 after removing the 3 no-op ancestry stubs -- every remaining test asserts real behavior)test_windows_setup.ps1: PASSFollow-up (out of scope for #476)
Residual squad/cast-name references found in a post-cleanup validation sweep (the
.copilot/skills/product tree, thegosquadalias,CONTRIBUTINGSQUAD_WORKTREES,setup.shcomment, and thetest_windows_setup.ps1:878"squad BEGIN/END markers" profile-marker test) are tracked separately in #481.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com