Skip to content

fix: VES ratio always 1.0 due to gold_sql used for both operands in iterated_execution #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nimaboubanian wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: VES ratio always 1.0 due to gold_sql used for both operands in iterated_execution #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion premsql/executors/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,13 @@ def iterated_execution(

if is_match["result"] == 1:
diff_list = [
# Bug fix: denominator must use predicted_sql, not gold_sql.
# The original code divided gold_time / gold_time (always 1.0),
# making VES meaningless. Correct formula: gold_time / predicted_time.
self.execute_sql(sql=gold_sql, dsn_or_db_path=dsn_or_db_path)[
"execution_time"
]
/ self.execute_sql(sql=gold_sql, dsn_or_db_path=dsn_or_db_path)[
/ self.execute_sql(sql=predicted_sql, dsn_or_db_path=dsn_or_db_path)[
"execution_time"
]
for _ in range(num_iterations)
Expand Down