Skip to content

Fix Flaky test: testDeserialization #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prathyushreddylpr wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix Flaky test: testDeserialization #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
118662c
Fixed flaky test
Oct 19, 2023
ffd28bd
Fix flaky test
Nov 2, 2023
45bb896
remove previous changes
Nov 2, 2023
099ecbf
fixed AttributeTest
Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...t/javascript-tests/src/test/java/org/apache/cxf/javascript/fortest/AttributeTestBean.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,13 @@
*
*/
@XmlRootElement(namespace = "uri:org.apache.cxf.javascript.testns")
@XmlType(namespace = "uri:org.apache.cxf.javascript.testns")
@XmlType(namespace = "uri:org.apache.cxf.javascript.testns",
propOrder = {
"element1",
"attribute1",
"element2",
"attribute2"
Comment on lines +33 to +36

@zzjas zzjas Nov 6, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the style here should be, but did you check if you need an extra indentation here?

@prathyushreddylpr prathyushreddylpr Nov 10, 2023

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes there were some styling rules for this repo and the indentation is provided adhering to all those rules, otherwise the build was failing.

})
public class AttributeTestBean {

//CHECKSTYLE:OFF
Expand Down
16 changes: 15 additions & 1 deletion ...avascript/javascript-tests/src/test/java/org/apache/cxf/javascript/fortest/TestBean1.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,21 @@
* Bean with a selection of elements suitable for testing the JavaScript client.
*/
@XmlRootElement(namespace = "uri:org.apache.cxf.javascript.testns")
@XmlType(namespace = "uri:org.apache.cxf.javascript.testns")
@XmlType(namespace = "uri:org.apache.cxf.javascript.testns",
propOrder = {
"stringItem",
"intItem",
"longItem",
"base64Item",
"optionalIntItem",
"optionalStringItem",
"optionalIntArrayItem",
"doubleItem",
"beanTwoItem",
"beanTwoNotRequiredItem",
"enumeration",
"enum2"
Comment on lines +34 to +45

@zzjas zzjas Nov 6, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

})
public class TestBean1 {

public TestBean1() {
Expand Down