fix: align Dockerfile Go version with go.mod (release blocker) - #21
Merged
Conversation
The Dockerfile build stage pinned golang:1.23, but a dependency forces the
go.mod `go` directive to 1.25.7, so `docker build` failed at `go mod download`
with "go.mod requires go >= 1.25.7". CI didn't catch it because the Actions
jobs use go-version-file (go.mod) while the Dockerfile hardcoded a version;
the release image build would have failed the same way on the v0.1.0 tag.
Bump the build stage to golang:1.25 and align CONTRIBUTING ("Go 1.25+").
Verified: image rebuilds (19.6 MB, nonroot 65532), /healthz 200, in-container
HEALTHCHECK exits 0, and the governor enforces a loop budget (402) in the
container.
Fixes #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release blocker found during pre-release container testing.
docker buildfailed atgo mod download:A dependency forces the
go.modgodirective to 1.25.7, but the Dockerfile build stage pinnedgolang:1.23. CI didn't catch it (Actions usego-version-file: go.mod; only the Dockerfile hardcoded a version), andrelease.yml's Docker build would have failed the same way on thev0.1.0tag.Fix: bump the build stage to
golang:1.25(≥ the go.mod directive) and alignCONTRIBUTING.md("Go 1.25+").Verified locally (
make docker+ run):/healthz→ 200,/versionstamped, in-containerHEALTHCHECKexits 0.Fixes #20
v0.1.0, or the release image build will fail.