refactor(deployers): make OpenTofu the sole engine + add NoOpDeployer#2
Closed
pradeepvrd wants to merge 1 commit into
Closed
refactor(deployers): make OpenTofu the sole engine + add NoOpDeployer#2pradeepvrd wants to merge 1 commit into
pradeepvrd wants to merge 1 commit into
Conversation
Owner
Author
|
Superseded: each Stage 1 substage is now a standalone PR against gke-labs/devops-bench. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 1 feedback 2a + 2b.
GCPDeployer;get_deployernow always buildsTFDeployer(gcp/kind selected via provider deduction + theDEPLOYERSvariable-resolver registry). A non-tofu/noopdeployer:now raisesConfigError.gcp.pyis now a variable-resolver module (kubetest2 anchor removed).NoOpDeployer(deployers/noop.py), activated byBENCH_NO_INFRA=true(precedence over task config) ordeployer: noop; returns localClusterInfo. Aligns with PR Add NoOpDeployer for infrastructure-free local runs gke-labs/devops-bench#73.Tests: 223 passed (deployers 18); deleted
test_deployers_gcp.py; addedtest_deployers_noop.py; behavior smoke covers tofu/noop/BENCH_NO_INFRA/ConfigError. ruff clean.