Skip to content

Fixed depthStencilReadMasks on Metal. #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smoogipoo merged 4 commits into from
Mar 22, 2026
Merged

Fixed depthStencilReadMasks on Metal. #75

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ef8f76
Fixed Point and Anisotropic sampler desc use the wrong standard.
MrScautHD Jun 20, 2025
619483c
Merge branch 'ppy:master' into master
MrScautHD Mar 21, 2026
936c4e0
Fixed Depthmask on Metal
MrScautHD Mar 21, 2026
c9d806b
Fixed mistake
MrScautHD Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Veldrid/MTL/MTLPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,13 @@ public MtlPipeline(ref GraphicsPipelineDescription description, MtlGraphicsDevic
{
var depthDescriptor = MTLUtil.AllocInit<MTLDepthStencilDescriptor>(
nameof(MTLDepthStencilDescriptor));
// Metal has no explicit depth-test enable flag on the depth-stencil descriptor.
// When depth testing is disabled we must force "always" to avoid unintentionally
// rejecting all fragments if DepthComparison is left at its default (Never).
depthDescriptor.depthCompareFunction = MtlFormats.VdToMtlCompareFunction(
description.DepthStencilState.DepthComparison);
description.DepthStencilState.DepthTestEnabled
? description.DepthStencilState.DepthComparison
: ComparisonKind.Always);
depthDescriptor.depthWriteEnabled = description.DepthStencilState.DepthWriteEnabled;

bool stencilEnabled = description.DepthStencilState.StencilTestEnabled;
Expand Down
Loading