preserve uniform names in SPIRV->GLSL compile because they are requir…#15
Open
jeske wants to merge 2 commits into
Open
preserve uniform names in SPIRV->GLSL compile because they are requir…#15jeske wants to merge 2 commits into
jeske wants to merge 2 commits into
Conversation
…ed for precompiled GLSL shaders to work
jeske
force-pushed
the
preserve_glsl_uniform_names
branch
from
39cb392 to
2bd808e
Compare
…h, so yes they are fixed, this test assures they stay fixed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes: veldrid#8
In order to use precompiled GLSL shaders, uniform names must be preserved into GLSL shader cross compiles, because the veldrid GLSL path uses name lookups to bind GLSL uniforms.
Prior to this fix glsl uniform names were renamed during debug shader compilation and lost during non-debug shader compilation.
This patch fixes both issues, by:
Test summary: total: 85, failed: 0, succeeded: 85, skipped: 0, duration: 36.9sAs far as I can tell, Veldrid:OpenGL only worked if you were willing to ship Veldrid.SPIRV into your runtime and use it to compile vulkan->SPIRV->glsl at runtime. There is no binary for SPIRV for mobile arm, and it's pretty unnecessary. It's also important to support precompiled shader users.
I found this bug while building a Veldrid backend for SilkyNvg that precompiles shaders to avoid shipping Veldrid.SPIRV, both because i dont want a SPIRV compiler dependency for a 2d vector drawling library, and because we run on android-vulkan, (and soon android-gles, and ios-metal)