Fix #448 and also allow to change a muted note to a real note#557
Open
sbonaime wants to merge 5 commits into
Open
Fix #448 and also allow to change a muted note to a real note#557sbonaime wants to merge 5 commits into
sbonaime wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Adds improved tab-entry handling for muted notes (x) to address issue #448 and to allow converting a muted note into a fretted note by typing digits.
Changes:
- Accept
xkey presses in the tab editor to insert a muted note directly when no note exists at the caret. - When typing a digit on a muted note, remove the Muted property and apply the typed fret number as a single undoable operation.
- Keep “play note while editing” behavior for numeric entry while skipping playback for muted-note insertion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
I have to check Copilot reviews ! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Add the option to directly insert a new muted note without requiring a number to be entered first.
Add the option to change a muted note to a regular note with some numbers
Fixes Issue(s)
#448