Release mutex per attachment, persist incrementally, allow stopSync to interrupt mid-batch#974
Open
khawarizmus wants to merge 1 commit into
Open
Release mutex per attachment, persist incrementally, allow stopSync to interrupt mid-batch#974khawarizmus wants to merge 1 commit into
khawarizmus wants to merge 1 commit into
Conversation
…ow mid-batch interruption - Implemented incremental persistence of attachment states during sync. - Updated `stopSync` to abort in-flight syncs promptly. - Adjusted `processAttachments` to commit state changes immediately after each attachment's I/O operation, improving responsiveness for concurrent operations.
🦋 Changeset detectedLatest commit: b839d66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports powersync-ja/powersync.dart#415 to the JS SDK. Closes #971.
The issue
The
AttachmentQueuemutex was held across the entire sync batch — including every per-attachment network upload/download. ForegroundsaveFile/deleteFile/ watched-attachment processing all contend for the same mutex, so a slow or stalled upload hung foreground operations for the full duration.stopSync()also couldn't interrupt mid-batch.The fix
SyncingService.processAttachmentsnow runs each attachment's I/O outside the mutex and persists state per-row via a briefwithContextre-acquire.stopSync()aborts a newAbortController; the sync loop pollsisActive()between attachments and exits within one attachment's processing time.syncLoopMutexThe Dart version gets serialization of sync triggers for free from
asyncMap. JS doesn't have that —setInterval,watchActiveAttachments.onDiff, andstatusChangedall callsyncStorage()independently, and the old wide mutex was implicitly serializing them. Added a dedicatedsyncLoopMutexto preserve that single-batch-at-a-time semantics without re-introducing the blocking. Foreground callers don't touch this lock, so #971 still goes away.AI Disclosure
This PR was created with the help of Opus 4.7 and Claude Code. I’ve reviewed the resulting code changes and made sure tests are passing locally.