Skip to content

[GOG-1783] Add npm_token secret to audiences-react workflow#558

Merged
xjunior merged 2 commits into
mainfrom
c-gerke-patch-1
May 19, 2026
Merged

[GOG-1783] Add npm_token secret to audiences-react workflow#558
xjunior merged 2 commits into
mainfrom
c-gerke-patch-1

Conversation

@c-gerke
Copy link
Copy Markdown
Member

@c-gerke c-gerke commented May 12, 2026

We need to explicitly define this secret so this Action can authenticate against our internal NPM registry.

This can be seen working in action in this run, which succeeded.

This should be merged after powerhome/github-actions-workflows#40, which changes the upstream Action that this repo pulls in.

We need to explicitly define this secret so this Action can authenticate against our internal NPM registry.
@c-gerke c-gerke self-assigned this May 12, 2026
@c-gerke c-gerke changed the title Add npm_token secret to audiences-react workflow [GOG-1783] Add npm_token secret to audiences-react workflow May 12, 2026
@c-gerke c-gerke marked this pull request as ready for review May 14, 2026 19:33
@c-gerke c-gerke requested review from a team as code owners May 14, 2026 19:33
@xjunior
Copy link
Copy Markdown
Contributor

xjunior commented May 18, 2026

Does this mean this library will no longer be published publicly, only to the internal repo?

@c-gerke
Copy link
Copy Markdown
Member Author

c-gerke commented May 18, 2026

Does this mean this library will no longer be published publicly, only to the internal repo?

@xjunior it won't affect the publishing of these packages, the change should just make sure that we authenticate to our internal NPM registry in order to pull the packages in when Renovate is working on the repo.

@xjunior xjunior merged commit 52adf2e into main May 19, 2026
15 checks passed
@xjunior xjunior deleted the c-gerke-patch-1 branch May 19, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants