Pin dependencies (main)#520
Open
renovate[bot] wants to merge 1 commit into
Open
Conversation
30d3dd3 to
4a10da6
Compare
3c52d0a to
2b44b42
Compare
01a69e3 to
9f365fc
Compare
c0e7ef0 to
fd5db22
Compare
0431881 to
f922efe
Compare
95617d1 to
7f8a4ac
Compare
7f8a4ac to
559dcb1
Compare
559dcb1 to
b1f40f6
Compare
c06324b to
646d3c5
Compare
646d3c5 to
ac02ca6
Compare
ac02ca6 to
34db579
Compare
8f00de6 to
6345041
Compare
6345041 to
3d2a798
Compare
3d2a798 to
f5aa538
Compare
| @@ -49,8 +49,8 @@ | |||
| "@fortawesome/fontawesome-free": "^6.4.0", | |||
| "@powerhome/eslint-config": "0.2.2", | |||
There was a problem hiding this comment.
Bug: Pinning @types/react to a React 18 version breaks compatibility for consumers using React 17, which is declared as a peerDependency.
Severity: HIGH
Suggested Fix
To maintain React 17 compatibility as declared in peerDependencies, pin @types/react to a compatible 17.x version. Alternatively, if dropping React 17 support, update the peerDependencies to require React 18+ and document this breaking change.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: audiences-react/package.json#L50
Potential issue: The project's `package.json` declares support for React 17 via its
`peerDependencies`. However, this change pins the `@types/react` dependency to version
`18.3.18`, which is specific to React 18 and not backward-compatible with React 17. This
will cause TypeScript compilation errors for any downstream consumer of this library who
is using React 17, as the types will not match their React version. The current CI setup
does not test against a React 17 environment, so this breaking change would not be
caught by automated tests.
Did we get this right? 👍 / 👎 to inform future reviews.
f5aa538 to
020d930
Compare
2ceed79 to
f769e08
Compare
f769e08 to
178258f
Compare
178258f to
8705fd8
Compare
8705fd8 to
10ee644
Compare
75d92aa to
d2a6390
Compare
d2a6390 to
3673949
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^18.2.15→18.3.18^18.2.7→18.3.55.1.0→5.2.0Add the preset
:preserveSemverRangesto your config if you don't want to pin your dependencies.Release Notes
facebook/react (eslint-plugin-react-hooks)
v5.2.0Compare Source
do/whileloops (@tyxla in #31720)Configuration
📅 Schedule: (in timezone America/New_York)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.