-
Notifications
You must be signed in to change notification settings - Fork 0
Fix weather tooltip, silent drop failures, and retry prompt divergence in Fishtank/Dispatch #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1f1a1fc
4ffdeed
7f053db
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| @echo off | ||
| setlocal enabledelayedexpansion | ||
| title OpenClaw Harbor - Starting... | ||
| title 🐟 OpenClaw Harbor | ||
| color 1F | ||
|
|
||
| REM Always run from the directory this script lives in | ||
|
|
@@ -77,11 +77,14 @@ if "!NEED_INSTALL!"=="1" ( | |
| echo. | ||
| call npm run rebuild 2>nul | ||
| if %ERRORLEVEL% neq 0 ( | ||
| echo ⚠️ Native rebuild had warnings ^(non-fatal — the app will still work^). | ||
| echo ⚠️ Native module build skipped — Visual Studio not found. | ||
| echo The terminal will use a basic shell instead. | ||
| echo Install Visual Studio Build Tools to enable full PTY support. | ||
| echo See: https://aka.ms/vs/buildtools | ||
| ) else ( | ||
|
Comment on lines
79
to
+84
|
||
| echo ✅ Native modules built successfully! | ||
|
Comment on lines
78
to
+85
|
||
| ) | ||
| echo. | ||
| echo ✅ Rebuild complete! | ||
| echo. | ||
| ) | ||
|
|
||
| echo 🌊 Launching OpenClaw Harbor... | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -62,9 +62,13 @@ if [ "$NEED_INSTALL" -eq 1 ]; then | |||||||||||||||||||||||||||||||
| echo " 🔧 Rebuilding native modules for Electron..." | ||||||||||||||||||||||||||||||||
| echo " (This makes sure node-pty works correctly.)" | ||||||||||||||||||||||||||||||||
| echo "" | ||||||||||||||||||||||||||||||||
| npm run rebuild 2>/dev/null || echo " ⚠️ Native rebuild had warnings (non-fatal — the app will still work)." | ||||||||||||||||||||||||||||||||
| echo "" | ||||||||||||||||||||||||||||||||
| echo " ✅ Rebuild complete!" | ||||||||||||||||||||||||||||||||
| if npm run rebuild 2>/dev/null; then | ||||||||||||||||||||||||||||||||
| echo " ✅ Native modules built successfully!" | ||||||||||||||||||||||||||||||||
| else | ||||||||||||||||||||||||||||||||
| echo " ⚠️ Native module build skipped — compiler toolchain not found." | ||||||||||||||||||||||||||||||||
| echo " The terminal will use a basic shell instead." | ||||||||||||||||||||||||||||||||
| echo " Install build-essential (Linux) or Xcode CLT (macOS) for full PTY support." | ||||||||||||||||||||||||||||||||
|
Comment on lines
+65
to
+70
|
||||||||||||||||||||||||||||||||
| if npm run rebuild 2>/dev/null; then | |
| echo " ✅ Native modules built successfully!" | |
| else | |
| echo " ⚠️ Native module build skipped — compiler toolchain not found." | |
| echo " The terminal will use a basic shell instead." | |
| echo " Install build-essential (Linux) or Xcode CLT (macOS) for full PTY support." | |
| REBUILD_LOG="rebuild-error.log" | |
| if npm run rebuild 2>"$REBUILD_LOG"; then | |
| echo " ✅ Native modules built successfully!" | |
| rm -f "$REBUILD_LOG" | |
| else | |
| echo " ⚠️ Native module rebuild failed." | |
| echo " The terminal may use a basic shell instead." | |
| echo " See $REBUILD_LOG for details, or rerun 'npm run rebuild' manually to view the full error output." | |
| echo " If the error mentions missing build tools, install build-essential (Linux) or Xcode CLT (macOS)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tooltip trigger is a non-focusable
<span>, so keyboard users can’t focus it to reveal the tooltip (Tooltip shows onFocus/onBlur only when something inside can receive focus). Consider making the trigger focusable (e.g.,tabIndex={0}) and ensuring it has an accessible name so the weather explanations are available without a mouse.