Skip to content

Fix CI lint failures and address repository quality issues - #8

Merged
potemkin666 merged 6 commits into
mainfrom
copilot/fix-formatting-warnings
May 14, 2026
Merged

Fix CI lint failures and address repository quality issues#8
potemkin666 merged 6 commits into
mainfrom
copilot/fix-formatting-warnings

Conversation

Copilot AI commented May 14, 2026

Copy link
Copy Markdown
Contributor

CI failing on Prettier format check (21 files) and ESLint errors (18 errors, 15 warnings). Analysis revealed additional gaps: missing security policy, contributing guide, outdated ESLint, and unclear dependency model.

Code Quality

ESLint errors eliminated (33 → 15 warnings, 0 errors):

  • Removed redundant /* global */ declarations conflicting with .eslintrc.json globals
  • Fixed unnecessary regex escapes (/\"/g/"/g)
  • Removed redundant Boolean cast (!Boolean(x.trim())!x.trim())
  • Prefixed unused helper functions with _ per convention

ESLint upgraded (8.57.1 → 10.3.0):

  • Migrated .eslintrc.jsoneslint.config.mjs (flat config requirement)
  • Added browser globals: TextEncoder, structuredClone, HTMLInputElement, AbortController, createImageBitmap, performance
  • Configured new v10 rules (no-useless-assignment, preserve-caught-error) as warnings

package.json:

  • Added "license": "MIT" field

Documentation

SECURITY.md: Vulnerability reporting process, response SLA, security features summary

CONTRIBUTING.md: Dev setup, code style enforcement (ESLint/Prettier), testing requirements, PR workflow, project structure map

README.md: Clarified browser-loaded dependencies (exifr, Tesseract.js, SparkMD5, sha256) - not npm deps because CDN-loaded

Formatting

Auto-fixed Prettier violations across 21 files per .prettierrc.json (140 char width, 2-space, LF).

Copilot AI and others added 6 commits May 14, 2026 13:34
Agent-Logs-Url: https://github.com/potemkin666/bluelens/sessions/c865ca1d-dd7f-49e1-93be-be3b2191e9b6

Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
Agent-Logs-Url: https://github.com/potemkin666/bluelens/sessions/c12cf656-ce2f-456c-b6bc-79c63725ae7f

Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
@potemkin666
potemkin666 marked this pull request as ready for review May 14, 2026 17:59
Copilot AI review requested due to automatic review settings May 14, 2026 17:59

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@potemkin666
potemkin666 merged commit 06be490 into main May 14, 2026
0 of 10 checks passed
@potemkin666
potemkin666 deleted the copilot/fix-formatting-warnings branch May 14, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants