Add standard project configuration files (.editorconfig, .nvmrc, LICENSE) - #7
Conversation
Agent-Logs-Url: https://github.com/potemkin666/bluelens/sessions/a7b9b536-0152-4c63-9c60-21f44aeaa684 Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
Agent-Logs-Url: https://github.com/potemkin666/bluelens/sessions/a7b9b536-0152-4c63-9c60-21f44aeaa684 Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
Agent-Logs-Url: https://github.com/potemkin666/bluelens/sessions/a7b9b536-0152-4c63-9c60-21f44aeaa684 Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
Agent-Logs-Url: https://github.com/potemkin666/bluelens/sessions/a7b9b536-0152-4c63-9c60-21f44aeaa684 Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
…SE) and fix .gitignore Agent-Logs-Url: https://github.com/potemkin666/bluelens/sessions/79d05ab6-d474-41d6-b056-1831dc9638aa Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
Agent-Logs-Url: https://github.com/potemkin666/bluelens/sessions/79d05ab6-d474-41d6-b056-1831dc9638aa Co-authored-by: potemkin666 <183807833+potemkin666@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d0c37080d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: npm install | ||
|
|
||
| - name: Check formatting | ||
| run: npm run format:check |
There was a problem hiding this comment.
This new required step fails immediately in the current tree: running npm run format:check at the repo root reports 21 files with style violations (including app.js, server.js, multiple docs, and UI assets), so every push/PR will fail before tests run. Either format the repo in this change or defer/relax this check to avoid a permanently red CI workflow.
Useful? React with 👍 / 👎.
| run: npm run format:check | ||
|
|
||
| - name: Run linter | ||
| run: npm run lint |
There was a problem hiding this comment.
The workflow now requires npm run lint, but this command currently exits non-zero with many errors in the tracked sources (I verified locally from repo root: 18 errors, e.g. no-useless-escape, no-extra-boolean-cast, and multiple no-redeclare failures), so CI will fail for all branches regardless of test health. This should be introduced together with a lint-fix pass or a temporary scoped lint target.
Useful? React with 👍 / 👎.
| scope: options.scope || "BlueLens", | ||
| }; | ||
|
|
||
| const minLevel = LOG_LEVELS[config.level] || LOG_LEVELS.INFO; |
There was a problem hiding this comment.
The minimum-level fallback treats DEBUG as falsy because LOG_LEVELS.DEBUG is 0, so setting BLUELENS_LOG_LEVEL=DEBUG still resolves to INFO and suppresses debug output. This breaks the documented behavior for debugging environments and makes the debug level effectively unusable.
Useful? React with 👍 / 👎.
Repository lacked editor consistency config, Node version pinning, and license file. Most tooling (ESLint, Prettier, npm scripts) already existed.
Changes
.editorconfig— 2-space indent, LF line endings, UTF-8 charset across editors; CRLF for Windows scripts.nvmrc— Pin Node.js 20 (aligns withpackage.jsonengines.node >= 18)LICENSE— MIT license.gitignore— Removepackage-lock.jsonexclusion (lockfiles should be committed)docs/PROJECT_CONFIG.md— Document all project configuration for contributorsContext
Package-lock.json, .gitignore, ESLint (.eslintrc.json), Prettier (.prettierrc.json), and npm scripts (
lint,lint:fix,format,format:check) were already present and functional.