prefill-concept-page#207
Conversation
|
Addressed What changed:
Validation run:
|
d794077 to
c51f833
Compare
|
Addressed mergeability follow-up on current What changed:
Validation run:
|
|
BLOCKING Project acceptance criteria
Story behavioral-assertion check
Docs-writing standard checklist
General website standard checklist
Review rules
Manual QA note
Required fix
|
|
Addressed the blocking citations feedback in commit What changed:
Why this resolves the blocker:
Validation run:
|
…l concept discovery surface]
…nearby serving and attention docs
…efill concept-page slice]
…efill concept-page slice]
…efill concept-page slice]
…efill concept-page slice]
f8f2b63 to
275d33b
Compare
|
Follow-up on rebased head What changed after the citation fix:
Validation rerun on the rebased head:
Current PR state:
|
…fill concept-page slice
|
Addressed the failing required What changed:
Why this resolves the blocker:
Validation rerun:
|
|
BLOCKING This comment supersedes the earlier clear-state comments. The prefill page itself is in good shape and CI is green on head Findings
Project acceptance criteria
Story behavioral-assertion check
Docs-writing standard checklist
General website standard checklist
Review rules
Quality-check evidence
Required fix
|
…efill concept-page slice]
|
Addressed the latest blocking shared-renderer feedback in commit What changed:
Why this resolves the blocker:
Validation rerun:
Browser verification on
|
|
CLEARING REVIEW This comment supersedes the earlier BLOCKING renderer feedback. On current head Project acceptance criteria
Story behavioral-assertion check
Docs-writing standard checklist
General website standard checklist
Review rules
Quality-check evidence
No blocking issues remain. This PR is ready to merge. |
{
"project": "Model Atlas — Prefill Canonical Concept Page",
"branchName": "prefill-concept-page",
"description": "Publish one canonical English
prefillconcept page, backed by the existing registry record and localized messages, so readers can understand the first serving-stage prompt pass, distinguish it from decode, and navigate cleanly to adjacent cache, latency, and attention docs.","context": {
"customerAsk": "Customer ask alignment: refill the queue with another fresh, narrow generation-serving concept slice so the active worker count returns to the requested range without reusing already-claimed PR surfaces. Add the canonical English concept page for
prefill, because readers need the missing broad explainer for the first serving stage before they can understand decode-time latency, KV cache reuse, and serving tradeoffs. Treat this as one narrow page-level slice on currentmain. Scope: create the canonical concept page, colocatedmessages/en.json, and any requiredassets.json, using the existing publishedconcept.prefillrecord; classify the page correctly with the project docs; connect aliases, tags, and related links so the page bridgeskv-cache,decode,prefill-decode-split,autoregressive-generation,time-to-first-token,attention, andgrouped-query-attention; and add only the minimum focused validation/tests needed for the touched page and registry-backed discovery surfaces. The explanation should define prefill in layperson terms, show why the prompt-processing pass is different from token-by-token decoding, and explain what readers should expect it to dominate in latency discussions. Keep the slice English-only and avoid reopening localization infrastructure or unrelated transformer foundation families. Acceptance criteria: theprefillconcept page exists as a canonical docs page on currentmain, resolves to the existing registry record, supports nearby discovery paths, and focused touched checks pass.","problem": "The repository already has the published
concept.prefillregistry record and a shippedprefillglossary page, plus nearby serving pages forkv-cache,decode,prefill-decode-split,autoregressive-generation, andtime-to-first-token, but it still lacks the canonical broad concept page that explains prefill as the prompt-processing stage before token-by-token generation begins. Readers therefore have to infer the idea from a glossary-sized page and narrower latency or cache pages instead of landing on one plain-language bridge that explains why prompt length changes early latency so much and why decode-time tradeoffs are different.","solution": "Publish a canonical English
/docs/concepts/prefillpage using the standard concept-page contract, bind it to the existingconcept.prefillregistry record, make the concept route the clear canonical broad explainer instead of leaving glossary-only discovery as the main surface, connect the required aliases, tags, and related-doc paths to nearby serving and attention pages, and add only the focused validation needed to prove route, message, registry, and discovery integrity for this narrow slice."},
"acceptanceCriteria": [
"A published canonical docs page exists for
prefillunder the concepts docs tree, with matching English messages and any required local assets.","Discovery surfaces treat the concept route as the canonical broad explainer for
prefilland do not leave readers with competing glossary-only canonical targets for the same concept.","The page resolves cleanly to the existing
concept.prefilldiscovery record and preserves accurate registry-backed discovery through aliases, tags, and related-doc relationships.","The page opens with one folded
openingSummary, explains prefill in layperson terms, clearly distinguishes the full-prompt prefill pass from token-by-token decode, and explains why prompt-side work often dominates time-to-first-token discussions.","Readers can navigate between
prefill,kv-cache,decode,prefill-decode-split,autoregressive-generation,time-to-first-token,attention, andgrouped-query-attentionthrough shipped nearby discovery surfaces with no broken or misleading links.","Focused validation covers the touched page contract plus the registry-backed related-doc, route, or search expectations needed for this slice, without broad unrelated test expansion.",
"The implementation stays English-only and does not reopen localization infrastructure, unrelated transformer-foundation-family pages, or broad taxonomy restructuring beyond what is required for this page to land cleanly.",
"Quality gate:
make typecheck,make lint, and focused tests pass."],
"userStories": [
{
"id": "prefill-concept-page-001",
"title": "Promote
prefillto the canonical concept discovery surface","description": "As a reader searching for prefill, I want the existing
concept.prefillrecord and route behavior to lead me to one canonical broad explainer so I do not have to piece the idea together from a glossary stub or narrower latency pages.","acceptanceCriteria": [
"The existing
concept.prefillrecord remains the canonical backing record and is updated only as needed with aliases, related ids, tags, citations, or other controlled metadata that match a broad concept page.","Discovery surfaces expose
/docs/concepts/prefillas the canonical broad explainer forprefill, and any retained glossary surface does not compete as the main canonical destination for the same concept.","Registry relationships connect the concept page to shipped nearby docs for
kv-cache,decode,prefill-decode-split,autoregressive-generation,time-to-first-token,attention, andgrouped-query-attention.","Discovery metadata distinguishes the broad
prefillconcept from neighboring serving-stage or latency pages without introducing duplicate canonical targets or broad taxonomy churn.","Typecheck passes",
"Tests pass"
],
"priority": 1,
"passes": true,
"notes": ""
},
{
"id": "prefill-concept-page-002",
"title": "Publish the canonical prefill concept page",
"description": "As a technical layperson learning about LLM serving, I want a dedicated
prefillconcept page so I can understand the prompt-processing stage before I dive into decode loops, cache reuse, or latency metrics.","acceptanceCriteria": [
"A canonical
prefilldocs page exists with matching frontmatter,messages/en.json, and any required localassets.json.","The page opens with one folded
openingSummaryand explains prefill in plain language before narrowing into inference-serving context.","The page clearly explains that prefill is the model pass that processes the entire existing prompt, builds the initial hidden-state and attention-side context needed for generation, and happens before the first generated token is emitted.",
"The page clearly explains that decode is different because it advances token by token after prefill rather than rereading the whole prompt as one initial stage.",
"The page clearly explains why readers should expect prefill to dominate time-to-first-token discussions as prompts get longer, without turning the page into a benchmark table or kernel-level tutorial.",
"Typecheck passes",
"Tests pass",
"Verify in browser using the Browser plugin"
],
"priority": 2,
"passes": true,
"notes": ""
},
{
"id": "prefill-concept-page-003",
"title": "Route readers between prefill and nearby serving and attention docs",
"description": "As a reader exploring serving tradeoffs, I want related docs, tags, and search surfaces to guide me into the broad
prefillexplainer and then onward to the right neighboring pages.","acceptanceCriteria": [
"Representative queries such as
prefill,prompt processing,prompt pass, andfirst token latencyreturn the canonical concept page as a direct relevant result rather than leaving readers only on narrower pages.","The concept page renders registry-backed related docs and tag surfaces that connect it to
kv-cache,decode,prefill-decode-split,autoregressive-generation,time-to-first-token,attention, andgrouped-query-attention.","At least one neighboring shipped page or discovery surface presents the new concept page as a navigable related destination so readers can reach it without typing the exact slug.",
"Browser-visible rendering shows the title, folded summary, tags, and related-doc links without broken links or missing-content placeholders.",
"Typecheck passes",
"Tests pass",
"Verify in browser using the Browser plugin"
],
"priority": 3,
"passes": true,
"notes": ""
},
{
"id": "prefill-concept-page-004",
"title": "Add focused validation for the prefill concept-page slice",
"description": "As a maintainer, I want targeted automated proof for the
prefillconcept-page slice so route, message, registry, and discovery regressions are caught without unrelated test expansion.","acceptanceCriteria": [
"Validation or tests confirm the
/docs/concepts/prefillroute,concept.prefillrecord, and default English messages resolve together.","Coverage asserts at least one page-specific discovery outcome and at least one page-specific related-link expectation for the new concept page.",
"Focused checks stay limited to touched content and discovery integrity rather than inventory snapshots, locale churn, or unrelated suite expansion.",
"Typecheck passes",
"Tests pass"
],
"priority": 4,
"passes": true,
"notes": ""
}
]
}