Remove Apple Authentication and Add Name Settings Feature

[popand]

Summary

This PR completely removes Apple authentication from the SunshAid app and introduces a comprehensive name settings feature that personalizes the user experience.

🚫 Authentication Removal

• Removed all Apple Sign In dependencies and authentication flows
• Deleted AuthenticationManager, KeychainService, and authentication views
• Updated entitlements to remove Sign in with Apple capability
• Simplified app navigation to go directly to dashboard without auth gates
• Replaced authenticated profile with SimpleProfileView

✨ Name Settings Feature

• Added comprehensive Settings UI with name input capability
• Personalized dashboard greetings based on user's name
• Graceful fallback to generic greetings when no name is set
• User-friendly name input sheet with focus management
• Integrated Settings access through Profile tab

🎨 UI/UX Improvements

• Redesigned PrivacyNoticeView with modern card-based layout
• Updated HelpSupportView to remove duplicate App Information section
• Consistent design language across Settings, Privacy, and Help views
• Enhanced content with emphasis on local data storage

📧 Content Updates

• Updated email addresses from sunshadeapp@gmail.com to sunshaidapp@gmail.com
• Updated privacy FAQ to emphasize local data storage: "All your personal data is stored locally on your device and never leaves your device"
• Removed duplicate sections and improved content organization

🧵 Technical Fixes

• Fixed threading violations in UserProfile by wrapping UserDefaults operations in DispatchQueue.main.async
• Resolved "Publishing changes from background threads" warnings in tests
• Updated tests to handle empty default names properly

🧪 Test Updates

• Updated UserProfileTests to allow empty default names
• Enhanced TimeUtilsTests to verify empty name handling
• All tests pass without threading warnings

Test plan

• App builds successfully without authentication dependencies
• Navigation flows directly to dashboard without auth screens
• Settings accessible through Profile tab
• Name input works with proper focus and validation
• Dashboard greetings personalize correctly with/without names
• All UI views display with consistent design patterns
• Tests pass without threading violations
• Privacy and Help content reflects local storage emphasis

🤖 Generated with Claude Code

[claude]

Claude finished @popand's task —— View job

---

Pull Request Review Complete ✅

I've completed a comprehensive review of this PR. Overall, this is a well-executed major refactor that removes Apple authentication and adds name personalization features. Here's my detailed feedback:

✅ Strengths

Threading Fixes (Excellent Work)

• Perfect fix in UserProfile.swift:48-104 - all UserDefaults operations properly wrapped in DispatchQueue.main.async
• Resolves the "Publishing changes from background threads" warnings
• Consistent pattern applied to all @Published property setters

Clean Architecture

• Excellent separation of concerns in the new Settings UI
• Reusable components (SettingsItem, PrivacyCard, SettingsSectionHeader)
• Well-structured navigation flow: Profile → Settings → Name input

User Experience

• Graceful fallback for empty names in TimeUtils.swift:19-34
• Focus management in name input sheet (@FocusState on line 452)
• Input validation with trimming (line 529)

⚠️ Issues to Address

Critical: Temperature Unit Duplication

• AccountSettingsView.swift:535-538 defines SettingsTemperatureUnit enum
• UserProfile.swift:4-43 has TemperatureUnit enum
• Lines 92-93 in AccountSettingsView directly save to UserDefaults, bypassing the UserProfile model
• Risk: Data inconsistency between the two temperature unit systems

Performance Concern: Multiple UserProfile Instances

• MainContentView.swift:54 and AccountSettingsView.swift:5 create separate @StateObject instances
• Should use UserProfile.shared consistently for singleton pattern
• Risk: Settings changes might not reflect immediately across views

Input Validation Gap

• Name input allows any string without length limits
• Risk: Extremely long names could cause UI layout issues
• Consider adding reasonable character limit (e.g., 50 characters)

📋 Minor Improvements

Error Handling

• UserProfile.swift:112 uses safe defaults for invalid enum values ✅
• Consider logging when fallbacks are used for debugging

Code Organization

• AccountSettingsView.swift is quite large (540+ lines)
• Consider extracting NameInputSheet and SkinTypeSelectionView to separate files

Memory Management

• All @StateObject and @ObservedObject usage looks correct
• Proper use of @Environment(\.presentationMode) for dismissal

🔒 Security Assessment

Authentication Removal: Low Risk

• Clean removal of Apple Sign In dependencies
• No authentication-dependent features remain
• App now functions as intended (local-only data storage)

Data Storage: Secure

• All data stored in UserDefaults (appropriate for this use case)
• No sensitive authentication tokens or credentials stored
• Privacy notice correctly emphasizes local storage

🧪 Test Coverage: Excellent

UserProfileTests.swift: Comprehensive coverage

• Tests all enum cases, conversions, and edge cases
• Proper state management validation
• Tests empty name handling (line 43)

TimeUtilsTests.swift: Thorough

• Tests personalized vs. generic greetings
• Edge cases: empty names, special characters, long names
• Good validation of greeting formats

🎯 Recommendations

1. Fix Temperature Unit Duplication (High Priority)

   // In AccountSettingsView, use UserProfile's enum consistently:
   @State private var selectedTemperatureUnit: TemperatureUnit = .fahrenheit
   // Remove custom SettingsTemperatureUnit enum

2. Standardize UserProfile Usage

   // Replace @StateObject with shared instance:
   @ObservedObject private var userProfile = UserProfile.shared

3. Add Name Length Validation

   // In NameInputSheet.swift:
   private let maxNameLength = 50
   // Truncate if needed: String(name.prefix(maxNameLength))

4. Extract Large View Components

   • Move NameInputSheet and SkinTypeSelectionView to separate files
   • Improves maintainability and compile times

Summary

This is a high-quality PR with excellent threading fixes and clean architecture. The main issues are architectural (enum duplication) rather than functional bugs. The code is well-tested and follows SwiftUI best practices. Address the temperature unit inconsistency and you'll have a solid implementation.

Recommendation: Approve with minor fixes 🚀

---

• Read and analyze key modified files
• Review UserProfile threading fixes
• Examine new Settings UI implementation
• Check test coverage and updates
• Evaluate security implications of auth removal
• Assess performance considerations
• Provide comprehensive feedback

[claude]

Claude finished @popand's task —— View job

---

Comprehensive PR Review ✅

I've completed a thorough review of this merged PR that removes Apple authentication and adds name personalization features. Here's my detailed assessment:

PR Review Tasks

• Analyze UserProfile.swift changes and threading fixes
• Review AccountSettingsView.swift UI implementation
• Examine authentication removal completeness
• Check TimeUtils.swift personalization logic
• Review test coverage and updates
• Assess security implications of auth removal
• Evaluate performance considerations
• Provide comprehensive feedback on code quality

---

✅ Strengths

Excellent Threading Fixes

• Perfect implementation in UserProfile.swift:48-104 - all UserDefaults operations properly wrapped in DispatchQueue.main.async
• Resolves the "Publishing changes from background threads" warnings that were causing test issues
• Consistent pattern applied across all @Published property setters

Clean Architecture & Code Quality

• Well-structured Settings UI with reusable components (SettingsItem, PrivacyCard, SettingsSectionHeader)
• Proper separation of concerns between UserProfile (data model) and UI views
• Good use of SwiftUI best practices: @StateObject, @ObservedObject, @FocusState

User Experience Design

• Graceful fallback for empty names in TimeUtils.swift:19-34
• Smart focus management in name input sheet (@FocusState on line 452)
• Input validation with trimming and character limits (50 chars max)
• Personalized greetings that update automatically via Combine publishers

Complete Authentication Removal

• ✅ Clean removal of AuthenticationManager.swift and KeychainService.swift
• ✅ Entitlements properly updated (removed Sign in with Apple capability)
• ✅ No remaining authentication imports or references found in codebase
• ✅ Navigation flow simplified to go directly to dashboard

---

⚠️ Issues to Address

Critical: Multiple UserProfile Instances

• MainContentView.swift:54 creates @StateObject private var userProfile = UserProfile() instead of using shared instance
• AccountSettingsView.swift:5 correctly uses UserProfile.shared
• Risk: Settings changes from AccountSettingsView might not immediately reflect in other parts of the app
• Fix: Use @ObservedObject private var userProfile = UserProfile.shared consistently

Performance: Singleton Pattern Inconsistency

• UserProfile.shared exists (line 162) but not used everywhere
• Multiple instances could lead to state synchronization issues
• Recommendation: Audit all UserProfile usage for consistency

Minor: Input Validation

• Name input allows any characters without sanitization
• While 50-character limit exists, no validation for potentially problematic characters
• Low priority but consider basic sanitization for special characters

---

🧪 Test Coverage: Excellent

UserProfileTests.swift: Comprehensive

• Tests all enum cases, conversions, and edge cases
• Proper state management validation
• Tests singleton behavior and empty name handling
• Good coverage of threading scenarios

TimeUtilsTests.swift: Thorough

• Tests personalized vs. generic greetings
• Edge cases: empty names, special characters, long names
• Good validation of greeting time ranges and formats

---

🔒 Security Assessment: Low Risk

Authentication Removal

• ✅ No authentication-dependent features remain
• ✅ App correctly functions as local-only data storage
• ✅ No sensitive tokens or credentials stored
• ✅ Privacy notice accurately reflects local storage approach

Data Storage

• ✅ All data stored in UserDefaults (appropriate for this use case)
• ✅ No network communication for user data
• ✅ Clean separation between weather data (external) and user data (local)

---

⚡ Performance Considerations

Positive

• Smart caching in DashboardViewModel for weekly session data
• Efficient Combine publishers for reactive updates
• Proper use of @MainActor for UI updates

Potential Improvement

• Consider lazy loading for Settings UI if it becomes complex
• Current implementation is well-optimized for current feature set

---

🎯 Recommendations

High Priority

1. Fix UserProfile Instance Usage

   // In MainContentView.swift, replace line 54:
   @ObservedObject private var userProfile = UserProfile.shared

Medium Priority

2. Extract Large View Components

   • AccountSettingsView.swift is 540+ lines
   • Consider moving NameInputSheet and SkinTypeSelectionView to separate files

3. Add Input Sanitization

   // In NameInputSheet, enhance validation:
   private func sanitizeName(_ input: String) -> String {
       input.trimmingCharacters(in: .whitespacesAndNewlines)
            .filter { !$0.isNewline }
   }

Low Priority

4. Error Handling Enhancement
   • UserProfile.swift:112 has good enum fallbacks
   • Consider logging when fallbacks are used for debugging

---

📋 Architecture Assessment

Strengths

• Clear data flow: UserProfile → DashboardViewModel → Views
• Proper reactive programming with Combine
• Good separation between settings, profile data, and weather services

Patterns

• ✅ Singleton pattern for UserProfile.shared
• ✅ MVVM pattern with DashboardViewModel
• ✅ Reactive updates via @Published properties

---

🏆 Summary

This is a high-quality PR that successfully removes Apple authentication while adding valuable personalization features. The code demonstrates:

• ✅ Excellent threading fixes that resolve test warnings
• ✅ Clean architecture following SwiftUI best practices
• ✅ Comprehensive test coverage for new functionality
• ✅ Complete authentication removal without loose ends
• ✅ User-friendly Settings UI with proper validation

Main Issue: Fix the UserProfile instance inconsistency in MainContentView.swift to ensure settings changes propagate correctly.

Recommendation: Approve with minor fixes 🚀

The implementation is solid, well-tested, and ready for production with the singleton fix applied.

---