Add Apple Weather attribution to comply with App Store requirements

[popand]

Summary

• Added Apple Weather attribution throughout the app to comply with App Store Review Guideline 5.2.5
• Addresses review feedback requiring clear display of the Apple Weather trademark for apps using WeatherKit
• Attribution includes Apple logo (🍎) + "Weather" text with link to legal attribution page

Changes Made

New Component

• Created WeatherAttributionView.swift - Reusable attribution component with two variants:
  • Standard view with background styling for prominent display
  • Compact view for space-constrained areas

Updated Views

• WeatherCard: Added attribution in 5-day forecast header
• UVIndexCard: Added compact attribution at bottom of card
• ProfileView: Added "Weather Attribution" menu item in Privacy & Legal section
  • Updated LegalMenuItem to support external URLs with appropriate icon

App Store Review Context

This PR addresses the following App Store review feedback:

Guideline 5.2.5 - Legal - Intellectual Property
The app displays Apple weather data but does not include the required Apple Weather attribution.
Apps that support WeatherKit must clearly display the Apple Weather trademark (🍎 Weather) and legal source link.

Test Plan

• Build succeeds without errors
• Attribution displays correctly on WeatherCard
• Attribution displays correctly on UVIndexCard
• Profile menu item links to Apple's legal attribution page
• All attribution links open https://weatherkit.apple.com/legal-attribution.html

Screenshots

The attribution now appears as "🍎 Weather" throughout the app with proper linking to Apple's legal page.

🤖 Generated with Claude Code

[claude]

Claude finished @popand's task —— View job

---

PR Review: Apple Weather Attribution Implementation

Review Tasks:

• Read and analyze WeatherAttributionView.swift (new component)
• Review changes to WeatherCard.swift
• Review changes to UVIndexCard.swift
• Review changes to ProfileView.swift
• Assess code quality and best practices
• Check for potential bugs and security concerns
• Evaluate performance considerations
• Assess test coverage needs
• Provide comprehensive feedback

---

✅ Overall Assessment

This PR successfully implements Apple Weather attribution to comply with App Store requirements. The implementation is clean, follows iOS development best practices, and properly integrates with the existing codebase.

🔍 Code Quality & Best Practices

Strengths:

• Clean component separation: WeatherAttributionView.swift provides both standard and compact variants with clear separation of concerns
• Consistent naming: Component names follow Swift conventions (WeatherAttributionView, CompactWeatherAttributionView)
• Good styling patterns: Uses existing app color scheme and consistent padding/spacing
• Proper SwiftUI patterns: Appropriate use of Link, HStack, and styling modifiers
• Integration consistency: Attribution placement follows logical UX patterns (prominent in forecast, compact in UV card, menu item in profile)

Minor improvements:

• Consider extracting the hardcoded URL ("https://weatherkit.apple.com/legal-attribution.html") to a constants file for maintainability
• The force unwrap on line 5 of WeatherAttributionView.swift could be safer, though the URL is static and unlikely to fail

🐛 Potential Issues

Low Risk:

• Force unwrapping: Lines 5 and 25 in WeatherAttributionView.swift use ! for URL creation. While safe for static URLs, consider using guard statements for defensive programming
• No accessibility labels: Consider adding .accessibilityLabel() modifiers for better VoiceOver support

🔒 Security Considerations

Good security practices:

• Uses HTTPS URL for attribution link ✅
• No sensitive data exposure ✅
• Proper use of Link component for external navigation ✅

⚡ Performance Considerations

Efficient implementation:

• Lightweight components with minimal view hierarchy ✅
• No expensive operations or heavy calculations ✅
• Proper use of SwiftUI's declarative patterns ✅
• No performance concerns identified ✅

🧪 Test Coverage

Current state:

• No unit tests for new attribution components
• Manual testing mentioned in PR description covers main scenarios

Recommendations:

• Add unit tests for WeatherAttributionView and CompactWeatherAttributionView
• Test URL accessibility and Link functionality
• Consider UI tests for attribution visibility in different views

📋 Detailed File Analysis

WeatherAttributionView.swift (Lines 1-36)

• ✅ Clean, reusable component design
• ✅ Proper styling with semantic colors
• ⚠️ Force unwrap on URL creation (lines 5, 25)
• ⚠️ Missing accessibility support

WeatherCard.swift (Line 89)

• ✅ Attribution properly placed in forecast header
• ✅ Good visual hierarchy with Spacer() alignment

UVIndexCard.swift (Lines 125-128)

• ✅ Compact attribution appropriately positioned at bottom
• ✅ Consistent with error state handling (only shows when no error)

ProfileView.swift (Lines 209-213)

• ✅ Enhanced LegalMenuItem to support external URLs
• ✅ Proper icon choice (apple.logo) and title
• ✅ Good separation in Privacy & Legal section

🎯 Recommendations

1. Safety improvements:

   // Replace force unwraps with safer alternatives
   guard let url = URL(string: "https://weatherkit.apple.com/legal-attribution.html") else {
       fatalError("Invalid attribution URL")
   }

2. Accessibility enhancements:

   .accessibilityLabel("Apple Weather attribution link")
   .accessibilityHint("Opens Apple's weather data attribution page")

3. Constants extraction:

   struct WeatherConstants {
       static let attributionURL = "https://weatherkit.apple.com/legal-attribution.html"
   }

4. Add unit tests for the new attribution components

✅ Approval Readiness

This PR is ready for approval with minor suggestions for future improvements. The implementation successfully addresses App Store requirements and maintains code quality standards.

---