Disable editors welcome guides in global setup#8
Merged
Hug0-Drelon merged 3 commits intoApr 28, 2026
Conversation
Hug0-Drelon
requested changes
Apr 23, 2026
Member
There was a problem hiding this comment.
Do you think it worths adding following preferences for core/edit-site?
{
welcomeGuide: false,
welcomeGuideStyles: false,
welcomeGuidePage: false,
welcomeGuideTemplate: false,
}Also, there is fullscreenMode preference, do you think we should set it to a standard value for our e2e tests.
Contributor
Author
Hug0-Drelon
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following https://github.com/polylang/polylang-pro/pull/2984#discussion_r3050662642.
What
Set
welcomeGuide,welcomeGuideTemplate(core/edit-post) andwelcomeGuide(core/edit-widgets) tofalseinglobal.setup.jsvia a REST call toPUT /wp/v2/users/me.Why
Several specs across Polylang Pro and Polylang were dismissing the block editor and widget editor welcome guides inline, either via
editor.setPreferences()or by clicking the close button.Moving this to global setup removes the need to handle it in each spec.
How
The REST call is placed after the
Promise.all()block.This is intentional:
resetPreferences()runs inside that block and makes aPUT /wp/v2/users/mewithpersisted_preferences: {}, which would overwrite our values.