Skip to content

Disable editors welcome guides in global setup#8

Merged
Hug0-Drelon merged 3 commits into
masterfrom
disable-editor-welcome-guides-in-global-setup
Apr 28, 2026
Merged

Disable editors welcome guides in global setup#8
Hug0-Drelon merged 3 commits into
masterfrom
disable-editor-welcome-guides-in-global-setup

Conversation

@Marianne380

Copy link
Copy Markdown
Contributor

Following https://github.com/polylang/polylang-pro/pull/2984#discussion_r3050662642.

What

Set welcomeGuide, welcomeGuideTemplate (core/edit-post) and welcomeGuide (core/edit-widgets) to false in global.setup.js via a REST call to PUT /wp/v2/users/me.

Why

Several specs across Polylang Pro and Polylang were dismissing the block editor and widget editor welcome guides inline, either via editor.setPreferences() or by clicking the close button.

Moving this to global setup removes the need to handle it in each spec.

How

The REST call is placed after the Promise.all() block.

This is intentional: resetPreferences() runs inside that block and makes a PUT /wp/v2/users/me with persisted_preferences: {}, which would overwrite our values.

Comment thread src/setup/global.setup.js

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it worths adding following preferences for core/edit-site?

{
	welcomeGuide: false,
	welcomeGuideStyles: false,
	welcomeGuidePage: false,
	welcomeGuideTemplate: false,
}

Also, there is fullscreenMode preference, do you think we should set it to a standard value for our e2e tests.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 2612d49 and 8549c53.

Added core/edit-site preferences, no current spec covers the site editor but might as well cover it now.

fullscreenMode added too.

@Marianne380 Marianne380 requested a review from Hug0-Drelon April 28, 2026 14:26
@Hug0-Drelon Hug0-Drelon merged commit 96a1702 into master Apr 28, 2026
2 checks passed
@Hug0-Drelon Hug0-Drelon deleted the disable-editor-welcome-guides-in-global-setup branch April 28, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants