ci: add cargo doc -D warnings check, fix rustdoc escaping#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RUSTDOCFLAGS="-D warnings" cargo doc --no-depsstep to CI so future rustdoc regressions are caught automaticallyflow.rswhere[*]appeared bare in doc comments (rustdoc interprets it as a doc link); escapes them as`[*]`Notes
The same
[*]fix also appears in PR #7 (feat/cli-complete). The changes are identical line-for-line so merging either order produces no conflict — git will see them as the same diff.Test plan
RUSTDOCFLAGS="-D warnings" cargo doc --manifest-path core/Cargo.toml --no-depsproduces no warnings locally🤖 Generated with Claude Code