Skip to content

feat: clean up session dir on session:stop event#14

Merged
tupe12334 merged 4 commits into
mainfrom
feat/session-cleanup
Jun 11, 2026
Merged

feat: clean up session dir on session:stop event#14
tupe12334 merged 4 commits into
mainfrom
feat/session-cleanup

Conversation

@tupe12334

Copy link
Copy Markdown
Member

Summary

  • Architecture.md specified session cleanup on session:stop as planned but not yet implemented
  • When polyhook emits session:stop, steplock now removes .steplock/sessions/<scope-key>/ and returns approve
  • Falls back to reading .steplock/sessions/fallback-id when session_id is empty — no new fallback IDs created during cleanup
  • If the scope dir doesn't exist (already cleaned or session never blocked), silently approves

Test plan

  • cargo test passes (4 new tests covering all cleanup paths)
  • session_stop_removes_scope_dir — creates a session, fires stop, verifies dir gone
  • session_stop_approves_when_no_scope_dir — no error when dir absent
  • session_stop_approves_when_no_steplock_dir — no error when .steplock/ absent
  • session_stop_uses_fallback_id_when_session_id_empty — fallback-id path cleaned up

🤖 Generated with Claude Code

@tupe12334 tupe12334 marked this pull request as ready for review June 11, 2026 20:14
@tupe12334 tupe12334 merged commit 8d6da0f into main Jun 11, 2026
3 checks passed
@tupe12334 tupe12334 deleted the feat/session-cleanup branch June 11, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant