feat: viewFn query at block, populate args with selected query#149
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR extends the existing “query at block + resubmit at Latest + restore UI inputs from workspace entry” pattern (introduced for runtime calls in #148) to view functions, so users can (a) run view function calls against a specific block and (b) reopen a saved result and have the block/function/args pre-populated for easy re-submission.
Changes:
- Replace custom pallet/function selectors with the shared
MetadataEntryInput+createMetadataEntryStateflow for view functions (including block picker + docs popover). - Add
latestBlocksupport to view-fn call IDs (vialatest_prefix) and include the executed block hash in workspace context for display. - When opening a saved view-fn result, synchronize the current UI selection (block, function, and encoded args) from the
callId.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/ViewFns/ViewFnWorkspaceEntry.tsx | Extends workspace context to include the executed blockHash. |
| src/pages/ViewFns/ViewFns.tsx | Switches to MetadataEntryInput using the new viewFnEntryState for consistent selection UX (including block picker). |
| src/pages/ViewFns/viewFns.state.ts | Introduces viewFnEntryState, adds latestBlock encoding in IDs, and threads blockHash into workspace context. |
| src/pages/ViewFns/ViewFnResults.tsx | Displays the executed block and synchronizes block/function/args into the query form when viewing a saved result. |
| src/pages/ViewFns/ViewFnQuery.tsx | Uses the shared entry state, reads selected block via selectedBlock$, stores latestBlock, and exports setInputValue for result-to-form synchronization. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
carlosala
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #148 but for view functions