Homework - #6
Open
Georgiy0 wants to merge 3 commits into
Open
Conversation
sergboec
reviewed
Dec 18, 2017
| @Override | ||
| public int run(String[] args) throws Exception { | ||
| final Configuration conf = this.getConf(); | ||
| final Job job = new Job(conf, "GetRow"); |
There was a problem hiding this comment.
Job считается deprecated, ужасов никаких нет, но будъте добры выберите из двух вариантов:
Напишите комментарий, почему новый код идёт с deprecated API или используйте рекомендуемое API 😄
sergboec
reviewed
Dec 18, 2017
| job.setJarByClass(GetRow.class); | ||
|
|
||
| job.setInputFormatClass(TextInputFormat.class); | ||
| job.setOutputFormatClass(TextOutputFormat.class); |
There was a problem hiding this comment.
sergboec
reviewed
Dec 18, 2017
| job.setOutputKeyClass(Text.class); | ||
| job.setOutputValueClass(IntWritable.class); | ||
|
|
||
| FileInputFormat.addInputPath(job, new Path(args[0])); |
There was a problem hiding this comment.
Где проверка на присутсвие аргументов, биг дата, бигдатой, но исключение ловить хотелось бы
sergboec
reviewed
Dec 18, 2017
|
|
||
| job.setMapperClass(MyMapper.class); | ||
| job.setReducerClass(MyReducer.class); | ||
| //job.setCombinerClass(MyReducer.class); |
sergboec
reviewed
Dec 18, 2017
| protected void map(Object key, Text value, Context context) throws IOException, InterruptedException { | ||
| final String line = value.toString(); | ||
|
|
||
| int pos = line.indexOf(0x09); |
There was a problem hiding this comment.
Это сработает для всех языков? Даже для тех где мультибайтовая кодировка?
И где проверка на корректность
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.