feat(python!): Do not reset seek position when scanning from file-like objects - #28619
Draft
nameexhaustion wants to merge 7 commits into
Draft
feat(python!): Do not reset seek position when scanning from file-like objects#28619nameexhaustion wants to merge 7 commits into
nameexhaustion wants to merge 7 commits into
Conversation
Contributor
|
The uncompressed lib size after this PR is 57.8590 MB. |
Contributor
|
The uncompressed lib size after this PR is 58.0356 MB. |
Contributor
|
The uncompressed lib size after this PR is 58.0356 MB. |
Contributor
|
The uncompressed lib size after this PR is 58.0356 MB. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nxs/2.0-csv-dispatch #28619 +/- ##
========================================================
- Coverage 80.54% 80.36% -0.19%
========================================================
Files 1868 1868
Lines 262210 262231 +21
Branches 3141 3141
========================================================
- Hits 211206 210747 -459
- Misses 50191 50671 +480
Partials 813 813 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently they get reset to the start. After this PR we will instead read from the existing seek position.
I.e. -