Skip to content

feat(python)!: Remove deprecated retries parameter - #28466

Open
BitWeaverDev wants to merge 1 commit into
pola-rs:mainfrom
BitWeaverDev:remove-retries-arg-27986
Open

feat(python)!: Remove deprecated retries parameter#28466
BitWeaverDev wants to merge 1 commit into
pola-rs:mainfrom
BitWeaverDev:remove-retries-arg-27986

Conversation

@BitWeaverDev

Copy link
Copy Markdown
Contributor

Summary

  • Removes the retries parameter (deprecated in 1.37.1 in favor of storage_options={"max_retries": n} via depr(python): Deprecate retries=n in favor of storage_options={"max_retries": n} #26155) from scan_parquet, read_parquet, read_parquet_metadata, scan_csv, scan_ipc, read_ipc, scan_ndjson, read_ndjson, Catalog.scan_table, and the corresponding write/sink functions (write_csv, write_ipc, write_parquet, sink_parquet, sink_csv, sink_ipc, sink_ndjson), which carried the identical deprecation.
  • Cleans up now-stale references in tests/conftest.py and tests/unit/io/cloud/test_cloud.py.

Closes #27986

Test plan

  • make lint (ruff, typos, mypy) passes
  • make test passes (17802 passed, 22 skipped, 9 xfailed)
  • Manually verified retries= now raises TypeError on all affected functions
  • Manually verified storage_options={"max_retries": n} still works end-to-end for read/write/scan across csv/parquet/ipc/ndjson

@BitWeaverDev
BitWeaverDev force-pushed the remove-retries-arg-27986 branch 2 times, most recently from a38b6c7 to df28149 Compare July 21, 2026 21:08
@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.64%. Comparing base (36e414b) to head (e9de9ad).
⚠️ Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28466      +/-   ##
==========================================
- Coverage   81.71%   81.64%   -0.08%     
==========================================
  Files        1870     1870              
  Lines      262992   262901      -91     
  Branches     3217     3207      -10     
==========================================
- Hits       214917   214636     -281     
- Misses      47243    47442     +199     
+ Partials      832      823       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The `retries` parameter was deprecated in 1.37.1 in favor of
`storage_options={"max_retries": n}` (pola-rs#26155). This removes it from
all scan/read/write/sink functions and the Catalog `scan_table` method.

Closes pola-rs#27986
@BitWeaverDev
BitWeaverDev force-pushed the remove-retries-arg-27986 branch from df28149 to e9de9ad Compare July 31, 2026 08:39
@BitWeaverDev
BitWeaverDev marked this pull request as ready for review July 31, 2026 08:39
@BitWeaverDev BitWeaverDev changed the title Remove retries arg 27986 feat(python)!: Remove deprecated retries parameter Jul 31, 2026
@github-actions github-actions Bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars and removed title needs formatting labels Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove retries argument from scan and read functions

1 participant