Skip to content

Add types and strengths to json - #2

Open
UshalNaidoo wants to merge 3 commits into
pokeweak:masterfrom
UshalNaidoo:add-types-and-strengths-to-json
Open

Add types and strengths to json#2
UshalNaidoo wants to merge 3 commits into
pokeweak:masterfrom
UshalNaidoo:add-types-and-strengths-to-json

Conversation

@UshalNaidoo

Copy link
Copy Markdown

Add types and strengths to json

Fix typos of Pokemon
Added types and strengths to the json file
@donbailon

Copy link
Copy Markdown
Member

@UshalNaidoo thanks for your work!

You need to add a coma in the line 2715.

Thanks!

image

Comment thread app/src/main/assets/pokemons.json Outdated
"strengths": [
"fighting",
"grass",
"bug"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the missing comma

@Sloy

Sloy commented Aug 11, 2016

Copy link
Copy Markdown
Member

@UshalNaidoo thank you for the contribution :)
If you fix the missing comma in the Json file we will merge it

Added a missing comma
@UshalNaidoo

Copy link
Copy Markdown
Author

Fixed the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants