Skip to content

Correct Parameter Hint Line rest Behaviour #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
solara404 merged 1 commit into from
May 11, 2026
Merged

Correct Parameter Hint Line rest Behaviour #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Prompt.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,7 +662,19 @@ fn tokenIndexAtCursor(input: []const u8, cursor_raw: usize) usize {
fn argIndexAtCursor(ctx: *const Prompt) ?usize {
const ti = tokenIndexAtCursor(ctx.input, ctx.cursor.raw);
if (ti == 0) return null;
return ti - 1;

const raw_arg_idx = ti - 1;
const cmd_ptr = command.registry.getPtr(ctx.selected_command) orelse
return raw_arg_idx;

// When the cursor reaches a `rest` parameter that same parameter index will
// be reported for all following tokens.
const params = cmd_ptr.parameters;
if (params.len != 0 and
params[params.len - 1].rest and
params.len <= raw_arg_idx) return params.len - 1;

return raw_arg_idx;
}

fn clearTwoLinesAndReturnToTop(w: *std.io.Writer) !void {
Expand Down
Loading