Skip to content

Adding Info Struct#25

Merged
solara404 merged 9 commits into
mainfrom
add_log_info
Jan 8, 2026
Merged

Adding Info Struct#25
solara404 merged 9 commits into
mainfrom
add_log_info

Conversation

@solara404

Copy link
Copy Markdown
Contributor

@solara404 solara404 requested a review from aaumar25 December 26, 2025 07:06

@aaumar25 aaumar25 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description is not added, cannot review

@solara404 solara404 marked this pull request as ready for review January 2, 2026 10:17

@aaumar25 aaumar25 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure about the carrier fields in the drivercom logging. If you have time to check it, please check it and make the description changes based on the observation after experimenting with the carrier fields.

Comment thread src/Log.zig Outdated
Comment thread src/Log.zig Outdated
Comment thread src/Log.zig Outdated
Comment thread src/Log.zig Outdated
Comment thread src/Log.zig Outdated
Comment thread src/Log.zig Outdated
Comment thread src/Log.zig Outdated
Comment thread src/Log.zig Outdated
@aaumar25

aaumar25 commented Jan 5, 2026

Copy link
Copy Markdown
Member

@solara404 If it is already ready for review, you can click re-request review button here. Also, try to resolve the conflicts as well so that the CI can run.

image

For future reference: try to not abreviate words that is not a standard to our term for the commit message. Avoid using chg, cmt since the word does not has meaning on its own. Also, your commit refactor: doc cmt Config.zig Info struct should have commit message as doc: Config.zig Info struct, because it just add doc comments instead of refactor.

@aaumar25

aaumar25 commented Jan 8, 2026

Copy link
Copy Markdown
Member

@solara404 What is the status of this PR?

@solara404

Copy link
Copy Markdown
Contributor Author

After review i would squash and merge

@solara404 solara404 requested a review from aaumar25 January 8, 2026 04:37

@aaumar25 aaumar25 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After addressing the comment, lgtm!

Comment thread src/Log.zig
Comment thread src/Log.zig
@solara404 solara404 merged commit b8e7add into main Jan 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants