Skip to content

Adding documentation comments#24

Merged
solara404 merged 2 commits into
mainfrom
refactor_add_description
Dec 22, 2025
Merged

Adding documentation comments#24
solara404 merged 2 commits into
mainfrom
refactor_add_description

Conversation

@solara404

Copy link
Copy Markdown
Contributor

added doc comment to Config.zig Info struct

@solara404 solara404 requested a review from aaumar25 December 22, 2025 05:02

@aaumar25 aaumar25 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will copy from other PR comments as the issue is the same.

Remember that PR title must be useful for users as the title will be used for generating release notes. refactor shall not be in the PR title as it is not useful for users. It is only useful for us, developer, thus it should only be contained in the commit title.

In addition, please refrain from abbreviating words in PR title. Also, pay attention on where and when to capitalize letter.

I have nothing to add regarding the changed files, everything looks good! Once you edit the PR title, you can merge it by yourself!

Comment thread src/Config.zig Outdated
try walkFields(@This(), "");
}

/// Provides metadata for the field, including its type, description,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Provides metadata for the field, including its type, description,
/// Provide field type of config fields and its metadata.

The only important description is the Drivercom.Config.Info is actually just a metadata for config fields. What kind of metadata given is not important to be written for Drivercom.Config.Info doc comments as it is clearly written in Drivercom.Config.Info.Meta. Maybe we can some information as well that the metadata of a field is given with prefix double underscore.

@solara404 solara404 changed the title refactor: doc cmt Config.zig Info struct Adding documentation comments Dec 22, 2025
@solara404 solara404 merged commit bcae234 into main Dec 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants