Skip to content

Clarify adding users to RBAC group#370

Open
JohnBlackwell wants to merge 2 commits into
mainfrom
update-rbac-adding-user-to-group
Open

Clarify adding users to RBAC group#370
JohnBlackwell wants to merge 2 commits into
mainfrom
update-rbac-adding-user-to-group

Conversation

@JohnBlackwell

@JohnBlackwell JohnBlackwell commented Jan 7, 2025

Copy link
Copy Markdown
Contributor

Fixes PROD-3076

@JohnBlackwell JohnBlackwell requested a review from a team as a code owner January 7, 2025 20:43
@netlify

netlify Bot commented Jan 7, 2025

Copy link
Copy Markdown

Deploy Preview for pluraldocs ready!

Name Link
🔨 Latest commit a709f29
🔍 Latest deploy log https://app.netlify.com/sites/pluraldocs/deploys/678ac49e75538000085efa32
😎 Deploy Preview https://deploy-preview-370--pluraldocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@linear

linear Bot commented Jan 7, 2025

Copy link
Copy Markdown

Comment thread pages/how-to/set-up/rbac.md Outdated
```

To add the specific user `michael@example.com` identified by that email to the RBAC rules.
To add the specific user `michael@example.com` identified by that email to the RBAC rules. For the purposes of this tutorial you will need to manually add the user to the Group created above by navigating to Settings > User Managment > Groups going to https://{you-console-instance}/settings/user-management/groups. Find the Edit Members tab in the group and add your member.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already added at line 31? Maybe it should really just be a callout to make it prominent. It also isn't relevant to the ClusterRoleBinding above as that's a user binding and doesn't need the group to be created

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough but there should still be some callout given directing that the user(s) be added to the group in the console. That could go on line 31. Something like "add users to this group ..."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you should use the {% callout severity="info" %} decorator to make it very prominent, that's what I meant by callout

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grep in the repo to see some examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants