fix: restore default USER coder in base image#18
Merged
Conversation
USER coder was removed in 3fc72fe when the starship config was moved to /etc/skel (which correctly requires root). However the image still needs to end with USER coder so containers start as the non-root coder user by default, rather than root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
USER coderwas inadvertently removed in 3fc72fe (fix: seed starship config via /etc/skel for home volume workspaces)/etc/skeloperations correctly need to run as root, but the image still needsUSER coderas the final directive so containers start as the non-rootcoderuser by defaultrootRoot cause
The commit message for 3fc72fe explicitly noted "Remove USER coder switch (no longer writing to home at build time)" — but the
USER coderat the end of the Dockerfile wasn't just there to own the home dir files; it sets the default runtime user for every container started from the image.