Test under JDK 26-ea#296
Conversation
📝 WalkthroughWalkthroughTwo GitHub Actions workflow files are updated to expand their Gradle CI build matrices. The Java version matrix in Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/gradle-native-compile.yml:
- Around line 10-12: The workflow's strategy.matrix currently lists java
versions but lacks fail-fast configuration; update the strategy to include
fail-fast: false (i.e., set strategy.fail-fast to false alongside the existing
matrix/java values) so the 26-ea job failure won't cancel the 21 and 25
jobs—modify the strategy block that contains "matrix" and "java:
['21','25','26-ea']" to add the fail-fast setting, mirroring the existing
gradle.yml behavior.
In @.github/workflows/gradle.yml:
- Around line 10-12: Add fail-fast: false under the workflow's strategy matrix
to prevent an early-access (26-ea) failure from cancelling stable-version jobs;
locate the strategy -> matrix block (the matrix: java: ['21','25','26-ea']
entry) and add fail-fast: false at the same strategy level so all job variants
run to completion regardless of EA failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 50977e64-b4cd-4baa-9ede-9963cc916320
📒 Files selected for processing (2)
.github/workflows/gradle-native-compile.yml.github/workflows/gradle.yml
No description provided.