Skip to content

Test under JDK 26-ea#296

Closed
mernst wants to merge 4 commits into
plume-lib:mainfrom
mernst:java-26-ea
Closed

Test under JDK 26-ea#296
mernst wants to merge 4 commits into
plume-lib:mainfrom
mernst:java-26-ea

Conversation

@mernst

@mernst mernst commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Mar 29, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Two GitHub Actions workflow files are updated to expand their Gradle CI build matrices. The Java version matrix in .github/workflows/gradle-native-compile.yml and .github/workflows/gradle.yml is changed from ['21', '25'] to ['21', '25', '26-ea']. This addition introduces Java 26 early access as a tested version in the continuous integration pipeline. All other workflow configuration, including job steps and GraalVM setup, remains unchanged. Each file requires a single line modification to the matrix definition.

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/gradle-native-compile.yml:
- Around line 10-12: The workflow's strategy.matrix currently lists java
versions but lacks fail-fast configuration; update the strategy to include
fail-fast: false (i.e., set strategy.fail-fast to false alongside the existing
matrix/java values) so the 26-ea job failure won't cancel the 21 and 25
jobs—modify the strategy block that contains "matrix" and "java:
['21','25','26-ea']" to add the fail-fast setting, mirroring the existing
gradle.yml behavior.

In @.github/workflows/gradle.yml:
- Around line 10-12: Add fail-fast: false under the workflow's strategy matrix
to prevent an early-access (26-ea) failure from cancelling stable-version jobs;
locate the strategy -> matrix block (the matrix: java: ['21','25','26-ea']
entry) and add fail-fast: false at the same strategy level so all job variants
run to completion regardless of EA failures.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 50977e64-b4cd-4baa-9ede-9963cc916320

📥 Commits

Reviewing files that changed from the base of the PR and between 14f595e and ab6ebc7.

📒 Files selected for processing (2)
  • .github/workflows/gradle-native-compile.yml
  • .github/workflows/gradle.yml

Comment thread .github/workflows/gradle-native-compile.yml Outdated
Comment thread .github/workflows/gradle.yml Outdated
@mernst mernst closed this Jun 6, 2026
@mernst mernst deleted the java-26-ea branch June 6, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant