chore(ci): add PR title validation workflow#77
Open
Gabrielpanga wants to merge 1 commit into
Open
Conversation
Ports pluggy-node's pr-title.yml. Runs on every PR to master and validates the title against Conventional Commits via amannn/action-semantic-pull-request@v6.1.1. Allowed types: feat, fix, perf, chore, docs, style, refactor, test, build, ci, revert. Scope is optional. The existing commit history in this repo already follows this style informally (fix:, feat:, feat(identity):, chore(deps):, etc.); this workflow just makes it enforced so titles can't drift.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports
pr-title.ymlfrompluggy-node. Runs on every PR targetingmasterand validates the title against Conventional Commits viaamannn/action-semantic-pull-request@v6.1.1.Allowed types:
feat,fix,perf,chore,docs,style,refactor,test,build,ci,revert. Scope is optional.The existing commit history in this repo already follows this style informally (
fix:,feat(identity):,chore(deps):, etc.); the workflow just makes it enforced so titles can't drift.Test plan
update stuff) and verify the check failsfeat: add thingand verify the check passesOther workflow gaps surfaced vs pluggy-node (not in this PR)
While porting this workflow, I diffed the rest of pluggy-node's CI against pluggy-java's. Surfacing here as follow-up candidates:
release.ymltags + publishes without running tests first — ifmasteris broken, a broken release ships to GitHub Packagesrelease.ymlonmvn -B verifyactions/checkout@v2,actions/setup-java@v1inmaven.ymlandmaven-publish.yml@v4pnpm audit). The gson CVE only surfaced via Dependabot, not CIorg.owasp:dependency-check-maventomaven.ymlGITHUB_TOKENinstead of scoped GitHub App tokenHappy to tackle any of these as separate PRs.