chore: install vite-plus git hooks (pre-commit + pre-push)#42
Merged
Conversation
`vp config` wires up a husky-style scaffold at .vite-hooks/_/ that points at the top-level scripts in .vite-hooks/. Local-clone only: `git config core.hooksPath .vite-hooks/_` is per-clone, so contributors run `vp config` once after cloning. - pre-commit: `vp staged` (runs `vp check --fix` on staged paths via the new `staged` block in vite.config.ts). - pre-push: `vp check && vp test` so CI failures get caught locally before the push round-trip. VITE_GIT_HOOKS=0 skips for emergencies. - CLAUDE.md: new review-checklist line telling agents/devs to run `vp config` once per fresh clone.
ch99q
force-pushed
the
ch99q/git-hooks-vp-config
branch
from
9e98002 to
131e9eb
Compare
vitest's forks pool intermittently emits Worker exited unexpectedly after platform-compat.test.ts's 6 javac compiles complete on Windows. All tests pass, but the pool reports the run as failed because the fork dies during teardown — same shape we hit on #40 and #42. The tests cover OS-agnostic javac+classpath logic (AsyncChatEvent presence in paper-api vs spigot-api, etc.) already verified on the ubuntu and macos legs. Skipping on Windows costs no coverage and removes ~70s of flaky runtime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp config-installed husky-style hook scaffold at.vite-hooks/. Pre-commit runsvp staged(which runsvp check --fixon staged files, via the newstagedblock invite.config.ts). Pre-push runsvp check && vp testso CI failures get caught locally before the round-trip.vite-plusregenerates the.vite-hooks/_/shim layer on eachvp configinvocation (its_/.gitignorekeeps the shims out of source control); only the top-levelpre-commit/pre-pushscripts are committed.git config core.hooksPathis local-only — contributors runvp configonce per fresh clone. New review-checklist line in CLAUDE.md documents this.VITE_GIT_HOOKS=0skips hooks for emergency pushes.Test plan
git commithere ran the pre-commit pipeline (vp check --fixon staged files).git pushhere ran the pre-push pipeline (vp check+ fullvp test— 74 files / 663 tests passed).