Fix 2027

[ewohnlich]

• I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
• I verified there aren't any other open pull requests for the same change.
• I followed the guidelines in Contributing to Plone.
• I successfully ran code quality checks on my changes locally.
• I successfully ran tests on my changes locally.
• If needed, I added new tests for my changes.
• If needed, I added documentation for my changes.
• I included a change log entry in my commits.

---

Closes PLONE_RESTAPI_DX_FIXTURE errors in Windows because of time.tzset() #2027

Important note: this fixes the layer so that it is usable in Windows for other projects, but the tests for this package do not pass in Windows yet. Per @davisagli " Even if there are remaining issues with time handling on Windows, we'd like to see those rather than this error". For future reference here are some things to note for Windows testing:

• There are failed tests for comparing path output locations, because it expects a POSIX style path separator
• test_statictime has failures due to the resulting datetime being off by more than the allowed threshold
• datetime.datetime.asdatetime() results in an OSError on Windows for any time before 1970!

[mister-roboto]

@ewohnlich thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[ewohnlich]

@jenkins-plone-org please run jobs

[ewohnlich]

Hmm, the test-no-uncommitted-doc-changes test is a mystery to me. I am unsure what it is meant to test and what I could have done to cause it to fail.

[davisagli]

@ewohnlich I'll take care of that one -- it's broken on master too. It's normal for it to start failing when there are updates to Plone packages that cause changes in the output. I should probably update the tests to run with a specific version instead of -latest so that we have more control over when to update them.