Skip to content

move template from plone.app.workflow to plone.app.layout#58

Merged
MrTango merged 11 commits into
masterfrom
3953-move-plone-app-workflow-to-plone-app-layout
Jun 4, 2026
Merged

move template from plone.app.workflow to plone.app.layout#58
MrTango merged 11 commits into
masterfrom
3953-move-plone-app-workflow-to-plone-app-layout

Conversation

@MrTango

@MrTango MrTango commented Feb 11, 2025

Copy link
Copy Markdown
Contributor

@mister-roboto

Copy link
Copy Markdown

@MrTango thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@MrTango MrTango changed the title remove unused updateSharingInfo view move template from plone.app.workflow to plone.app.layout Feb 12, 2025
@MrTango

MrTango commented Feb 12, 2025

Copy link
Copy Markdown
Contributor Author

Since we have some API code in the sharing view, we can't just move it to plone.app.layout.
We need to separate the UI code from the API code.
To do this we will create a new sharing view in plone.app.layout with a plone.app.layout.interfaces.IClassicUI BrowserLayer which subclasses the sharing view from plone.app.workflow and add's the classic UI related parts like the call and handle_form methods. As long as plone.app.layout is available, this will be the view one get's while calling for the sharing view. In Plone 7 plone.app.layout will become optional and when it is not present, one will get the base view in plone.app.workflow with the API related code, instead of the one from plone.app.layout. No code needs to change in plone.restapi.

For addon's overriding the sharing view, they need to update their Browserlayer to subclass from plone.app.layout.interfaces.IClassicUI BrowserLayer.

Comment thread plone/app/workflow/browser/sharing.py Outdated
@MrTango MrTango marked this pull request as ready for review February 13, 2025 10:17
@MrTango MrTango requested a review from ale-rt February 14, 2025 10:29
@MrTango

MrTango commented May 31, 2026

Copy link
Copy Markdown
Contributor Author

@jenkins-plone-org please run jobs

@MrTango MrTango merged commit 63166a7 into master Jun 4, 2026
12 checks passed
@MrTango MrTango deleted the 3953-move-plone-app-workflow-to-plone-app-layout branch June 4, 2026 11:43
@mauritsvanrees

Copy link
Copy Markdown
Member

@gforcada This merge should have resulted in mr.roboto adding plone.app.workflow to the checkouts of coredev 6.3. But that failed. The log has this (most recent line first):

2026-06-04 13:43:26,426 INFO Commit: on coredev - do nothing

2026-06-04 13:43:26,426 INFO Commit: on plone/buildout.coredev 6.3 [0708b01f46711df34cfb88c14b58e64e1ab83346](https://github.com/plone/buildout.coredev/commit/0708b01f46711df34cfb88c14b58e64e1ab83346)

2026-06-04 13:43:18,566 INFO Commit: LETS COMMIT ON COREDEV

2026-06-04 13:43:18,566 WARNI Got an exception while trying to commit, give it another try

2026-06-04 13:43:15,531 INFO Commit: on coredev - do nothing

2026-06-04 13:43:15,531 INFO Commit: on plone/buildout.coredev 6.3 [737cb5a64019f66d4305b1c501d06aa7bc4f3ae0](https://github.com/plone/buildout.coredev/commit/737cb5a64019f66d4305b1c501d06aa7bc4f3ae0)

2026-06-04 13:43:14,284 INFO add plone.app.workflow to checkouts.cfg of buildout.coredev 6.3

2026-06-04 13:43:14,284 WARNI Error lines received while fetching: error: failed to push some refs to 'https://github.com/plone/buildout.coredev.git'

2026-06-04 13:43:12,436 INFO Commit: LETS COMMIT ON COREDEV

Maybe something is out of sync on the server.

I will add it to the checkouts myself.

mauritsvanrees added a commit to plone/buildout.coredev that referenced this pull request Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

5 participants