Validate imported field values#39
Conversation
|
@petschki thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
|
small change, big outcome 🙈 there are a lot validation errors from different packages when validating imported registry.xml values. Just to name one: |
mauritsvanrees
left a comment
mauritsvanrees
left a comment
There was a problem hiding this comment.
Apparently there is a new option to mark PRs as draft, which you did, and I just marked this pull request as ready for review, which was probably the wrong button to push. :-)
I haven't tried it locally, but the idea seems good.
| try: | ||
| importRegistry(context) | ||
| except zope.schema._bootstrapinterfaces.RequiredMissing: | ||
| # this should raise RequiredMissing |
There was a problem hiding this comment.
This can be done with:
with self.assertRaises(zope.schema._bootstrapinterfaces.RequiredMissing):
importRegistry(context)
There was a problem hiding this comment.
Thank's for the hint ... I'll change that
|
@mauritsvanrees draft PRs are quite cool, but once marked as "ready" you cannot go back. This PR is definitely not ready for merging, because it breaks a lot. If we agree to introduce validation of registry values we have to change/fix several other packages to pass all tests again. I think I take it on my Buschenschank todo list ... |
|
Is this still a a thing? |
4 participants
fixes #38