Skip to content

3953 move plone app registry to plone app layout#437

Merged
petschki merged 3 commits into
masterfrom
3953-move-plone-app-registry-to-plone-app-layout
Jun 10, 2026
Merged

3953 move plone app registry to plone app layout#437
petschki merged 3 commits into
masterfrom
3953-move-plone-app-registry-to-plone-app-layout

Conversation

@faro76

@faro76 faro76 commented May 28, 2026

Copy link
Copy Markdown
  • I signed and returned the Plone Contributor Agreement, and received and accepted an invitation to join a team in the Plone GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Contributing to Plone.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • If needed, I added new tests for my changes.
  • If needed, I added documentation for my changes.
  • I included a change log entry in my commits.

Test together on Jenkins:

https://github.com/plone/plone.app.registry/pull/113
https://github.com/plone/plone.app.layout/pull/437

@mister-roboto

Copy link
Copy Markdown

@faro76 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@faro76 faro76 requested a review from ale-rt May 28, 2026 12:45
@petschki petschki closed this Jun 10, 2026
@petschki petschki force-pushed the 3953-move-plone-app-registry-to-plone-app-layout branch from 155075d to 3c2616b Compare June 10, 2026 07:03
@petschki

Copy link
Copy Markdown
Member

Sorry, this got closed with my latest force-push ... I will continue to cleanup and rebase here today

@petschki petschki reopened this Jun 10, 2026
@mister-roboto

Copy link
Copy Markdown

@faro76 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki petschki merged commit 07401a3 into master Jun 10, 2026
12 checks passed
@petschki petschki deleted the 3953-move-plone-app-registry-to-plone-app-layout branch June 10, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants