Skip to content

bugfix for w3c error stated in issue #259 #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
woolyseal wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bugfix for w3c error stated in issue #259 #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cba350
bugfix for w3c error stated in issue #259
Aug 24, 2021
f8440e8
Merge branch 'master' into iss259
Sep 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/259.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix the w3c validation error in the common.py by removing the role-attribute from the label [wkbkhard]
2 changes: 1 addition & 1 deletion plone/app/layout/viewlets/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ class GlobalSectionsViewlet(ViewletBase):

_opener_markup_template = (
u'<input id="navitem-{uid}" type="checkbox" class="opener" />'
u'<label for="navitem-{uid}" role="button" aria-label="{title}"></label>' # noqa: E 501
u'<label for="navitem-{uid}" aria-label="{title}"></label>' # noqa: E 501

@ale-rt ale-rt Aug 24, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing # noqa: E 501 can be removed given the line is shorter than 80 chars now.

)
_item_markup_template = (
u'<li class="{id}{has_sub_class} nav-item">'
Expand Down