Skip to content

Add Recyclebin support for discussion#284

Closed
rohnsha0 wants to merge 2 commits into
mainfrom
rohnsha0/recyclebin
Closed

Add Recyclebin support for discussion#284
rohnsha0 wants to merge 2 commits into
mainfrom
rohnsha0/recyclebin

Conversation

@rohnsha0

@rohnsha0 rohnsha0 commented Sep 22, 2025

Copy link
Copy Markdown
Member

to be merged with plone/Products.CMFPlone#4223

image

@mister-roboto

Copy link
Copy Markdown

@rohnsha0 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli

Copy link
Copy Markdown
Member

I want to use soft-deletion for comments instead as implemented in #285. Okay if I close this?

@rohnsha0

Copy link
Copy Markdown
Member Author

I want to use soft-deletion for comments instead as implemented in #285. Okay if I close this?

yes, go ahead... not an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants