Skip to content

Move built-in vocabulary permissions to plone.app.vocabulary#237

Open
ksuess wants to merge 3 commits into
masterfrom
move-vocab-permissions-to-p.a.vocabularies
Open

Move built-in vocabulary permissions to plone.app.vocabulary#237
ksuess wants to merge 3 commits into
masterfrom
move-vocab-permissions-to-p.a.vocabularies

Conversation

@ksuess

@ksuess ksuess commented Nov 5, 2021

Copy link
Copy Markdown
Member

@mister-roboto

Copy link
Copy Markdown

@ksuess thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ksuess

ksuess commented Nov 5, 2021

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@ksuess ksuess changed the title Update vocabulary.py: deferredimport of 'DEFAULT_PERMISSION', 'DEFAUL… Move built-in vocabulary permissions to plone.app.vocabulary Nov 24, 2021
@ksuess ksuess requested a review from jensens November 24, 2021 15:16

@mauritsvanrees mauritsvanrees left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this belongs together with plone/plone.app.vocabularies#67.

On the one hand it makes sense to move these permission definitions to where the vocabularies are. On the other hand plone.app.vocabularies does not use these permissions. So I am on the fence on this one.
I can imagine though that plone.restapi may want to use these permissions as well.

One of the permissions defined here is for plone.app.multilingual, although it could be removed from the list because it is the same as the DEFAULT_PERMISSION.

@jensens Do you want to comment?

ksuess added 2 commits May 15, 2022 10:19
…T_PERMISSION_SECURE', 'PERMISSIONS' from plone.app.vocabularies
@mauritsvanrees mauritsvanrees force-pushed the move-vocab-permissions-to-p.a.vocabularies branch from 00ac441 to bf36d19 Compare May 15, 2022 08:19
@jensens

jensens commented Jun 13, 2023

Copy link
Copy Markdown
Member

I would put permissions to the domain they are in, vocabularies to pa.vocabularies and multilingual to pam.
Another option would be to (ab)use plone.base for those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants