Conversation
Add `zpretty-check-path` and `zpretty-options` inputs to the backend-lint reusable workflow so callers can override the checked path (previously hardcoded to `src`) and pass extra command-line options to zpretty. Document all backend-lint inputs in the shared-workflows reference. Refs #389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new optional inputs to the
backend-lintreusable workflow so callers can control howzprettyis invoked:zpretty-check-path(default'src') — the path checked byzpretty. Previously hardcoded tosrc.zpretty-options(default'') — additional command-line options passed through tozpretty(e.g.--extend-exclude).Changes
.github/workflows/backend-lint.yml: new inputs wired into thezpretty --checkinvocation.docs/sources/reference/shared-workflows.md: documented allbackend-lintinputs in a table and added a usage example.news/389.feature: changelog fragment.Notes
The
zpretty-optionsvalue is expanded by bash in the workflowrun:step (not Make), so a regex end anchor must be a single$— the documented example reflects this:Refs #389