Preserve configlet title i18n Messages on edits - fixes #4344#4345
Preserve configlet title i18n Messages on edits - fixes #4344#4345szakitibi wants to merge 1 commit into
Conversation
|
Tibor Szakmany the email address in your commit does not match an email in your GitHub account. Thus it is impossible to determine whether you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement If you have sent in your Plone Contributor Agreement, and received and accepted an invitation to join the Plone GitHub organization, then you might need to either add the email address on your Agreement to your GitHub account or change the email address in your commits. If you need to do the latter, then you should squash the commits with your matching email and push them. Add more emails to your GitHub account: Change the email address in your commits: |
|
@szakitibi thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
b336924 to
1fa8723
Compare
|
Regarding the force-push, it switched commit author to the one with signed Plone Contributor Agreement. |
GenericSetup
controlpanel.xmlallows configlets to be registered with translated titles (i18n:attributes="title"). This works in multilingual sites and Site Setup on classic UI show translated configlets.However using ZMI/portal_controlpanel/manage_editActionsForm breaks translations here:
Products.CMFPlone/src/Products/CMFPlone/PloneControlPanel.py
Line 174 in 6212f6f
The
zope.i18n.message.Messageis replaced with a plainstr.This PR fixes the issue by restoring the i18n Message from the stored action if there is no change to the name.
Closes #4344