Use extended expression context for Control Panel actions#4341
Conversation
|
@erral thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
0eec8ba to
0820160
Compare
|
@jenkins-plone-org please run jobs |
gforcada
left a comment
There was a problem hiding this comment.
LGTM without being an expert on this area of the code 😄
|
@jenkins-plone-org please run jobs |
davisagli
left a comment
There was a problem hiding this comment.
When is the control panel context NOT the portal? I'm not sure we should try to support that, since most control panels are global.
|
When using addons like To ease the managing of such scenarios, See an example: https://github.com/collective/lineage.controlpanels/pull/13/changes#diff-a8395fbc089e4b85d51d34d18e6f6908a8fa864e291f81647f9bd542e3ad0746R23 |
This PR introduces a more flexible expression context for Control Panel actions.
By using
get_current_context(), we can now use TALES expressions that depend on the current context (e.g., checking if a specific behavior is enabled on the current folder or document) when deciding whether to show a configlet in the control panel.Changes:
get_current_context()toProducts.CMFPlone.utilsto reliably find the current content object from the request.PloneControlPanel.enumConfigletsto use the current context for expression evaluation.get_current_context().PloneControlPanel.py.Fixes #3288