[RECYCLE BIN] Implement permission for accessing recyclebin#4176
[RECYCLE BIN] Implement permission for accessing recyclebin#4176rohnsha0 wants to merge 7 commits into
Conversation
…dd tests for permission checks
…g items in the recycle bin
stevepiercy
left a comment
stevepiercy
left a comment
There was a problem hiding this comment.
Casing of recycle bin. Otherwise this looks good. Needs a technical review.
…anage recycle bin"
|
|
||
| def _get_context(self): | ||
| """Get the context (Plone site)""" | ||
| return self.context |
There was a problem hiding this comment.
This doesn't appear to be used.
| # Additional check for Manager or Site Administrator roles | ||
| user = sm.getUser() | ||
| user_roles = user.getRolesInContext(context) | ||
| return "Manager" in user_roles or "Site Administrator" in user_roles |
There was a problem hiding this comment.
Remove the explicit check for roles. That's already included in the checkPermission call (it checks that the current user has one of the roles for which the permission has been granted)
| """Stores deleted content items""" | ||
|
|
||
| # Permission for managing recycle bin | ||
| MANAGE_RECYCLEBIN = "Products.CMFPlone.ManageRecycleBin" |
There was a problem hiding this comment.
This should be "Manage recycle bin". checkPermission uses the permission's title, not its id
| 1. They have the ManageRecycleBin permission, or | ||
| 2. They are a Manager or Site Administrator, or | ||
| 3. They are the owner of the item, or | ||
| 4. They deleted the item |
There was a problem hiding this comment.
3 and 4 are a nice idea, but currently the "Manage recycle bin" permission is only granted to Managers and Site Administrators, which means that the recycle bin can't be accessed by users who don't have one of those roles.
There are a lot of details to get right here. I strongly suggest we focus on making this work only for Managers and Site Administrators for now, and then come back to it later if we want to provide more filtered access to other users.
There was a problem hiding this comment.
done
will soon create an issue for tracking
edit: #4185
| # Log in as the test user | ||
| user = self.portal.acl_users.getUser("testuser") | ||
| user = user.__of__(self.portal.acl_users) | ||
| newSecurityManager(None, user) |
There was a problem hiding this comment.
Use the login function from plone.app.testing
rohnsha0
changed the base branch from
rohnsha0-plip-recyclebin
to
rohnsha0-plip-recyclebin-patch
rohnsha0
changed the base branch from
rohnsha0-plip-recyclebin-patch
to
rohnsha0-plip-recyclebin
|
@davisagli Is this ready to merge, or do you have any remaining concerns? |
|
@cekk We decided this is out of scope for the first version of the recycle bin. Too many potential edge cases. For now, the recycle bin is available to site admins only. |
6 participants
fixes #4173
includes:-