Skip to content

Draft: Experiment with optimizing moves#3834

Draft
davisagli wants to merge 4 commits into
masterfrom
experimental-move-optimization
Draft

Draft: Experiment with optimizing moves#3834
davisagli wants to merge 4 commits into
masterfrom
experimental-move-optimization

Conversation

@davisagli

@davisagli davisagli commented Aug 18, 2023

Copy link
Copy Markdown
Member

I'm opening this to try out an optimization to make moving large folders faster by avoiding complete reindexing.

This is based on https://github.com/4teamwork/ftw.copymovepatches

@mister-roboto

Copy link
Copy Markdown

@davisagli thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@davisagli

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@davisagli

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@davisagli

Copy link
Copy Markdown
Member Author

@jenkins-plone-org please run jobs

@mamico

mamico commented Mar 19, 2026

Copy link
Copy Markdown
Member

In my opinion, we should provide a way to configure the list of context-aware indexes (e.g., via ZCA, environment variables, or registry). This would allow developers who implement a new context-influenced index to easily register it alongside the existing ones (path, getId, etc.).

@davisagli Would you be okay with me integrating this directly into the PR? I'd be happy to handle it as soon as I can find some time.

@davisagli

Copy link
Copy Markdown
Member Author

@mamico In the long run I'd like to see this get refactored into a PR for CMFCore so that we don't need a monkeypatch.

@mamico

mamico commented Jun 5, 2026

Copy link
Copy Markdown
Member

@mamico In the long run I'd like to see this get refactored into a PR for CMFCore so that we don't need a monkeypatch.

@davisagli If you have some time and want to take a look, here is an initial implementation: zopefoundation/Products.CMFCore#161 It's not fully complete or tested yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants