Skip to content

feat: expose sub_account_name on Number resource#317

Open
avinashp-plivo wants to merge 1 commit into
masterfrom
FNT-370
Open

feat: expose sub_account_name on Number resource#317
avinashp-plivo wants to merge 1 commit into
masterfrom
FNT-370

Conversation

@avinashp-plivo
Copy link
Copy Markdown
Contributor

Summary

Adds subAccountName field + getSubAccountName() getter to the Number resource POJO, mirroring the new sub_account_name JSON field added to GET /v1/Account/{auth_id}/Number/ listing responses.

Jackson's global PropertyNamingStrategy.SNAKE_CASE (configured in PlivoClient) automatically maps subAccountNamesub_account_name, so no @JsonProperty annotation is needed.

Companion to:

  • plivo/pkg#168 (merged) — adds SubAccountName on AuthInfoResponse
  • plivo/number_service#743 — populates sub_account_name in the rented-numbers response
  • plivo/message-router#291 — analogous change for senderid listing
  • feat: expose sub_account_name on Number resource plivo-php#370 — same field exposed on PHP SDK

Test plan

  • CI build green
  • Verified manually against a staging response that returns sub_account_name for subaccount-owned numbers and null for parent-account numbers (verified upstream on number_service)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant